Report the correct editing status to Unity. Fixes #934

There's two issues going on here

  - The `loggedInUser` field wasn't getting seeded with user information on load,
	so checking whether the current user owns a lock would always fail until the
	connections changed event got triggered somehow

  - `GetLock` didn't account for not having user information, so if the user was
	logged out, it would default to not allowing any edits. Since the info wasn't
	getting seeded, it would always report files as being locked by someone else.
	It now defaults to allowing edits if the user isn't signed in. Now, this isn't
	a bug, but if the user is not signed in, all bets are kinda off on validating
	locks. We should probably warn the user that we can't check whether they own
	the lock, but we should probably not lock down Unity entirely because of it.

Author: shana

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/LfsLocksModificationProcessor.cs

@@ -21,6 +21,8 @@ public static void Initialize(IEnvironment env, IPlatform plat)
             environment = env;
             platform = plat;
             platform.Keychain.ConnectionsChanged += UserMayHaveChanged;
+            // we need to do this to get the initial user information up front
+            UserMayHaveChanged();
 
             repository = environment.Repository;
             if (repository != null)
@@ -37,19 +39,21 @@ public static string[] OnWillSaveAssets(string[] paths)
 
         public static AssetMoveResult OnWillMoveAsset(string oldPath, string newPath)
         {
-            return IsLocked(oldPath) || IsLocked(newPath) ? AssetMoveResult.FailedMove : AssetMoveResult.DidNotMove;
+            return IsLockedBySomeoneElse(oldPath) || IsLockedBySomeoneElse(newPath) ? AssetMoveResult.FailedMove : AssetMoveResult.DidNotMove;
         }
 
         public static AssetDeleteResult OnWillDeleteAsset(string assetPath, RemoveAssetOptions option)
         {
-            return IsLocked(assetPath) ? AssetDeleteResult.FailedDelete : AssetDeleteResult.DidNotDelete;
+            return IsLockedBySomeoneElse(assetPath) ? AssetDeleteResult.FailedDelete : AssetDeleteResult.DidNotDelete;
         }
 
+        // Returns true if this file can be edited by this user
         public static bool IsOpenForEdit(string assetPath, out string message)
         {
             var lck = GetLock(assetPath);
-            message = lck.HasValue ? "File is locked for editing by " + lck.Value.Owner : null;
-            return !lck.HasValue;
+            var canEdit = !IsLockedBySomeoneElse(lck);
+            message = !canEdit ? "File is locked for editing by " + lck.Value.Owner : null;
+            return canEdit;
         }
 
         private static void RepositoryOnLocksChanged(CacheUpdateEvent cacheUpdateEvent)
@@ -66,9 +70,14 @@ private static void UserMayHaveChanged()
             loggedInUser = platform.Keychain.Connections.Select(x => x.Username).FirstOrDefault();
         }
 
-        private static bool IsLocked(string assetPath)
+        private static bool IsLockedBySomeoneElse(GitLock? lck)
         {
-            return GetLock(assetPath).HasValue;
+            return lck.HasValue && !lck.Value.Owner.Name.Equals(loggedInUser);
+        }
+
+        private static bool IsLockedBySomeoneElse(string assetPath)
+        {
+            return IsLockedBySomeoneElse(GetLock(assetPath));
         }
 
         private static GitLock? GetLock(string assetPath)
@@ -78,9 +87,9 @@ private static bool IsLocked(string assetPath)
 
             GitLock lck;
             var repositoryPath = environment.GetRepositoryPath(assetPath.ToNPath());
-            if (!locks.TryGetValue(repositoryPath, out lck) || lck.Owner.Name.Equals(loggedInUser))
-                return null;
-            return lck;
+            if (locks.TryGetValue(repositoryPath, out lck))
+                return lck;
+            return null;
         }
     }
 }