Moar logging

Author: shana

src/GitHub.Api/Tasks/ProcessTask.cs

@@ -104,7 +104,7 @@ public void Run()
 
             try
             {
-                Logger.Trace($"Running '{Process.StartInfo.FileName.ToNPath().FileName} {taskName}'");
+                Logger.Trace($"Running '{Process.StartInfo.FileName} {taskName}'");
 
                 Process.Start();
 
@@ -154,9 +154,11 @@ public void Run()
                     }
                 }
             }
-            catch (Win32Exception ex)
+            catch (Exception ex)
             {
-                var errorCode = ex.NativeErrorCode;
+                var errorCode = -42;
+                if (ex is Win32Exception)
+                    errorCode = ((Win32Exception)ex).NativeErrorCode;
 
                 StringBuilder sb = new StringBuilder();
                 if (Process.StartInfo.Arguments.Contains("-credential"))
@@ -172,12 +174,6 @@ public void Run()
                 }
                 thrownException = new ProcessException(errorCode, sb.ToString(), ex);
             }
-            catch (Exception ex)
-            {
-                thrownException = new ProcessException(Process.HasExited ? Process.ExitCode : -42,
-                    "Unknown error",
-                    ex);
-            }
 
             if (thrownException != null || errors.Count > 0)
                 onError?.Invoke(thrownException, string.Join(Environment.NewLine, errors.ToArray()));