Trace log important exceptions

Author: shana

src/GitHub.Api/Installer/GitInstaller.cs

@@ -218,7 +218,12 @@ private GitInstallationState GetZipsIfNeeded(GitInstallationState state)
                 return state;
 
             var downloader = new Downloader();
-            downloader.Catch(e => true);
+            downloader
+                .Catch(e =>
+                {
+                    LogHelper.Trace(e, "Failed to download");
+                    return true;
+                });
             downloader.Progress(p => ((Progress)Progress)?.UpdateProgress(20 + (long)(20 * p.Percentage), 100, downloader.Name));
             if (!state.GitZipExists && !state.GitIsValid && state.GitPackage != null)
                 downloader.QueueDownload(state.GitPackage.Uri, installDetails.ZipPath);
@@ -255,7 +260,11 @@ private GitInstallationState ExtractGit(GitInstallationState state)
                 var unzipTask = new UnzipTask(cancellationToken, installDetails.GitZipPath,
                         gitExtractPath, sharpZipLibHelper,
                         environment.FileSystem)
-                    .Catch(e => true);
+                    .Catch(e =>
+                    {
+                        LogHelper.Trace(e, "Failed to unzip " + installDetails.GitZipPath);
+                        return true;
+                    });
                 unzipTask.Progress(p => ((Progress)Progress)?.UpdateProgress(40 + (long)(20 * p.Percentage), 100, unzipTask.Name));
                 var path = unzipTask.RunWithReturn(true);
                 var target = state.GitInstallationPath;
@@ -276,7 +285,11 @@ private GitInstallationState ExtractGit(GitInstallationState state)
                 var unzipTask = new UnzipTask(cancellationToken, installDetails.GitLfsZipPath,
                         gitLfsExtractPath, sharpZipLibHelper,
                         environment.FileSystem)
-                    .Catch(e => true);
+                    .Catch(e =>
+                    {
+                        LogHelper.Trace(e, "Failed to unzip " + installDetails.GitLfsZipPath);
+                        return true;
+                    });
                 unzipTask.Progress(p => ((Progress)Progress)?.UpdateProgress(60 + (long)(20 * p.Percentage), 100, unzipTask.Name));
                 var path = unzipTask.RunWithReturn(true);
                 var target = state.GitLfsExecutablePath;

src/GitHub.Api/Primitives/Package.cs

@@ -33,8 +33,12 @@ public static Package Load(IEnvironment environment, UriString packageFeed)
             if (!feed.FileExists() || now.Date > environment.UserSettings.Get<DateTimeOffset>(key).Date)
             {
                 feed = new DownloadTask(TaskManager.Instance.Token, environment.FileSystem, packageFeed, environment.UserCachePath)
-                        .Catch(e => true)
-                        .RunWithReturn(true);
+                    .Catch(e =>
+                    {
+                        LogHelper.Trace(e, "Failed to download " + packageFeed);
+                        return true;
+                    })
+                    .RunWithReturn(true);
 
                 if (feed.IsInitialized)
                     environment.UserSettings.Set<DateTimeOffset>(key, now);