Merge pull request #585 from github-for-unity/fixes/fix-download-location

Download portable git zip files to a known location

Author: shana

src/GitHub.Api/Application/ApplicationManagerBase.cs

@@ -72,8 +72,7 @@ public void Run(bool firstRun)
                         }
                     });
 
-                var applicationDataPath = Environment.GetSpecialFolder(System.Environment.SpecialFolder.LocalApplicationData).ToNPath();
-                var installDetails = new GitInstallDetails(applicationDataPath, true);
+                var installDetails = new GitInstallDetails(Environment.UserCachePath, true);
                 var gitInstaller = new GitInstaller(Environment, CancellationToken, installDetails);
 
                 // if successful, continue with environment initialization, otherwise try to find an existing git installation

src/GitHub.Api/Installer/GitInstaller.cs

@@ -25,10 +25,13 @@ class GitInstallDetails
 
         private readonly bool onWindows;
 
-        public GitInstallDetails(NPath targetInstallPath, bool onWindows)
+        public GitInstallDetails(NPath pluginDataPath, bool onWindows)
         {
             this.onWindows = onWindows;
-            var gitInstallPath = targetInstallPath.Combine(ApplicationInfo.ApplicationName, PackageNameWithVersion);
+
+            PluginDataPath = pluginDataPath;
+
+            var gitInstallPath = PluginDataPath.Combine(PackageNameWithVersion);
             GitInstallationPath = gitInstallPath;
 
             if (onWindows)
@@ -56,6 +59,7 @@ public NPath GetGitLfsExecutablePath(NPath gitInstallRoot)
                 : gitInstallRoot.Combine("libexec", "git-core", GitLfsExecutable);
         }
 
+        public NPath PluginDataPath { get; }
         public NPath GitInstallationPath { get; }
         public string GitExecutable { get; }
         public NPath GitExecutablePath { get; }
@@ -178,21 +182,20 @@ private NPath MoveGitAndLfs(NPath gitExtractPath, NPath gitLfsExtractPath, NPath
 
         private ITask CreateDownloadTask()
         {
-            var tempZipPath = NPath.CreateTempDirectory("git_zip_paths");
-            gitArchiveFilePath = tempZipPath.Combine("git.zip");
-            gitLfsArchivePath = tempZipPath.Combine("git-lfs.zip");
+            gitArchiveFilePath = installDetails.PluginDataPath.Combine("git.zip");
+            gitLfsArchivePath = installDetails.PluginDataPath.Combine("git-lfs.zip");
 
             var downloadGitMd5Task = new DownloadTextTask(TaskManager.Instance.Token, environment.FileSystem,
-                installDetails.GitZipMd5Url, tempZipPath);
+                installDetails.GitZipMd5Url, installDetails.PluginDataPath);
 
             var downloadGitTask = new DownloadTask(TaskManager.Instance.Token, environment.FileSystem,
-                installDetails.GitZipUrl, tempZipPath);
+                installDetails.GitZipUrl, installDetails.PluginDataPath);
 
             var downloadGitLfsMd5Task = new DownloadTextTask(TaskManager.Instance.Token, environment.FileSystem,
-                installDetails.GitLfsZipMd5Url, tempZipPath);
+                installDetails.GitLfsZipMd5Url, installDetails.PluginDataPath);
 
             var downloadGitLfsTask = new DownloadTask(TaskManager.Instance.Token, environment.FileSystem,
-                installDetails.GitLfsZipUrl, tempZipPath);
+                installDetails.GitLfsZipUrl, installDetails.PluginDataPath);
 
             return
                 downloadGitMd5Task.Then((b, s) => { downloadGitTask.ValidationHash = s; })

src/GitHub.Api/Tasks/DownloadTask.cs

@@ -99,30 +99,53 @@ protected virtual string RunDownload(bool success)
                 {
                     Logger.Trace($"Download of {Url} to {Destination} Attempt {attempts + 1} of {RetryCount + 1}");
 
-                    using (var destinationStream = fileSystem.OpenWrite(Destination, FileMode.Append))
+                    var fileExistsAndValid = false;
+                    if (Destination.FileExists())
                     {
-                        result = Utils.Download(Logger, Url, destinationStream,
-                            (value, total) =>
+                        if (ValidationHash == null)
+                        {
+                            Destination.Delete();
+                        }
+                        else
+                        {
+                            var md5 = fileSystem.CalculateFileMD5(Destination);
+                            result = md5.Equals(ValidationHash, StringComparison.CurrentCultureIgnoreCase);
+
+                            if (result)
                             {
-                                UpdateProgress(value, total);
-                                return !Token.IsCancellationRequested;
-                            });
+                                Logger.Trace($"Download previously exists & confirmed {md5}");
+                                fileExistsAndValid = true;
+                            }
+                        }
                     }
 
-                    if (result && ValidationHash != null)
+                    if (!fileExistsAndValid)
                     {
-                        var md5 = fileSystem.CalculateFileMD5(TargetDirectory);
-                        result = md5.Equals(ValidationHash, StringComparison.CurrentCultureIgnoreCase);
-
-                        if (!result)
+                        using (var destinationStream = fileSystem.OpenWrite(Destination, FileMode.Append))
                         {
-                            Logger.Warning($"Downloaded MD5 {md5} does not match {ValidationHash}. Deleting {TargetDirectory}.");
-                            fileSystem.FileDelete(TargetDirectory);
+                            result = Utils.Download(Logger, Url, destinationStream,
+                                (value, total) =>
+                                {
+                                    UpdateProgress(value, total);
+                                    return !Token.IsCancellationRequested;
+                                });
                         }
-                        else
+
+                        if (result && ValidationHash != null)
                         {
-                            Logger.Trace($"Download confirmed {md5}");
-                            break;
+                            var md5 = fileSystem.CalculateFileMD5(Destination);
+                            result = md5.Equals(ValidationHash, StringComparison.CurrentCultureIgnoreCase);
+
+                            if (!result)
+                            {
+                                Logger.Warning($"Downloaded MD5 {md5} does not match {ValidationHash}. Deleting {Destination}.");
+                                fileSystem.FileDelete(TargetDirectory);
+                            }
+                            else
+                            {
+                                Logger.Trace($"Download confirmed {md5}");
+                                break;
+                            }
                         }
                     }
                 }

src/tests/IntegrationTests/Installer/GitInstallerTests.cs

@@ -35,6 +35,7 @@ public override void TestFixtureTearDown()
         }
 
         [Test]
+        [Category("DoNotRunOnAppVeyor")]
         public void GitInstallTest()
         {
             var gitInstallationPath = TestBasePath.Combine("GitInstall").CreateDirectory();