Merge pull request #111 from github-for-unity/fixes/keychain-adapter-update-clear

Fixes to Update/Clear in KeychainAdapter

Author: shana

src/GitHub.Api/Authentication/KeychainAdapter.cs

@@ -17,11 +17,13 @@ public void Set(ICredential credential)
         public void UpdateToken(string token)
         {
             Credential.UpdateToken(token);
+            OctokitCredentials = new Credentials(OctokitCredentials.Login, token);
         }
 
         public void Clear()
         {
             OctokitCredentials = Credentials.Anonymous;
+            Credential = null;
         }
 
         /// <summary>

src/tests/UnitTests/Authentication/KeychainTests.cs

@@ -392,7 +392,7 @@ public void ShouldConnectSetCredentialsTokenAndSave()
             keychainAdapter.Credential.Token.Should().Be(token);
             keychainAdapter.OctokitCredentials.AuthenticationType.Should().Be(AuthenticationType.Basic);
             keychainAdapter.OctokitCredentials.Login.Should().Be(username);
-            keychainAdapter.OctokitCredentials.Password.Should().Be(password);
+            keychainAdapter.OctokitCredentials.Password.Should().Be(token);
 
             keychain.Save(hostUri).Wait();
 
@@ -472,10 +472,7 @@ public void ShouldConnectSetCredentialsAndClear()
 
             keychain.Clear(hostUri, false).Wait();
 
-            keychainAdapter.Credential.Should().NotBeNull();
-            keychainAdapter.Credential.Host.Should().Be(hostUri);
-            keychainAdapter.Credential.Username.Should().Be(username);
-            keychainAdapter.Credential.Token.Should().Be(password);
+            keychainAdapter.Credential.Should().BeNull();
             keychainAdapter.OctokitCredentials.AuthenticationType.Should().Be(AuthenticationType.Anonymous);
             keychainAdapter.OctokitCredentials.Login.Should().BeNull();
             keychainAdapter.OctokitCredentials.Password.Should().BeNull();