Task success means it ran to completion and didn't fail (but if we catch an exception, it's not a success)

Author: shana

src/GitHub.Api/Tasks/ProcessTask.cs

@@ -213,7 +213,6 @@ class ProcessTask<T> : TaskBase<T>, IProcessTask<T>
     {
         private IOutputProcessor<T> outputProcessor;
         private ProcessWrapper wrapper;
-        private bool finished = false;
 
         public event Action<string> OnErrorData;
         public event Action<IProcess> OnStartProcess;
@@ -303,7 +302,6 @@ public override T RunWithReturn(bool success)
                 RaiseOnStart,
                 () =>
                 {
-                    finished = true;
                     try
                     {
                         if (outputProcessor != null)
@@ -352,7 +350,7 @@ public override string ToString()
 
         public Process Process { get; set; }
         public int ProcessId { get { return Process.Id; } }
-        public override bool Successful { get { return finished && ((!taskFailed && Process.ExitCode == 0) || (taskFailed && exceptionWasHandled)); } }
+        public override bool Successful { get { return base.Successful && Process.ExitCode == 0; } }
         public StreamWriter StandardInput { get { return wrapper?.Input; } }
         public virtual string ProcessName { get; protected set; }
         public virtual string ProcessArguments { get; }
@@ -486,7 +484,7 @@ public override string ToString()
 
         public Process Process { get; set; }
         public int ProcessId { get { return Process.Id; } }
-        public override bool Successful { get { return Task.Status == TaskStatus.RanToCompletion && Process.ExitCode == 0; } }
+        public override bool Successful { get { return base.Successful && Process.ExitCode == 0; } }
         public StreamWriter StandardInput { get { return wrapper?.Input; } }
         public virtual string ProcessName { get; protected set; }
         public virtual string ProcessArguments { get; }

src/GitHub.Api/Tasks/TaskBase.cs

@@ -491,10 +491,10 @@ public override string ToString()
             return $"{Task?.Id ?? -1} {Name} {GetType()}";
         }
 
-        public virtual bool Successful { get { return !taskFailed || exceptionWasHandled; } }
+        public virtual bool Successful { get { return hasRun && !taskFailed; } }
+        public bool IsCompleted { get { return hasRun; } }
         public string Errors { get; protected set; }
         public Task Task { get; protected set; }
-        public bool IsCompleted { get { return hasRun; /*(Task as IAsyncResult).IsCompleted;*/ } }
         public WaitHandle AsyncWaitHandle { get { return (Task as IAsyncResult).AsyncWaitHandle; } }
         public object AsyncState { get { return (Task as IAsyncResult).AsyncState; } }
         public bool CompletedSynchronously { get { return (Task as IAsyncResult).CompletedSynchronously; } }