More cleanup

Author: StanleyGoldman

src/GitHub.Api/Application/ApiClient.cs

@@ -32,14 +32,9 @@ public ApiClient(IKeychain keychain, IProcessManager processManager, ITaskManage
         {
             Guard.ArgumentNotNull(keychain, nameof(keychain));
 
-            if (host == null)
-            {
-                host = UriString.ToUriString(HostAddress.GitHubDotComHostAddress.WebUri);
-            }
-            else
-            {
-                host = new UriString(host.ToRepositoryUri().GetComponents(UriComponents.SchemeAndServer, UriFormat.SafeUnescaped));
-            }
+            host = host == null
+                ? UriString.ToUriString(HostAddress.GitHubDotComHostAddress.WebUri)
+                : new UriString(host.ToRepositoryUri().GetComponents(UriComponents.SchemeAndServer, UriFormat.SafeUnescaped));
 
             HostAddress = HostAddress.Create(host);
 

src/GitHub.Api/Application/ApplicationManagerBase.cs

@@ -210,8 +210,6 @@ public void SetupGit(GitInstaller.GitInstallationState state)
                             return true;
                         }).RunSynchronously();
 
-                    Logger.Trace("Credential Helper: {0}", credentialHelper);
-
                     if (string.IsNullOrEmpty(credentialHelper))
                     {
                         Logger.Warning("No Windows CredentialHelper found: Setting to wincred");

src/GitHub.Api/Authentication/ILoginManager.cs

@@ -10,7 +10,7 @@ interface ILoginManager
         /// <summary>
         /// Attempts to log into a GitHub server with a username and password.
         /// </summary>
-        /// <param name="host"></param>
+        /// <param name="host">The host.</param>
         /// <param name="username">The username.</param>
         /// <param name="password">The password.</param>
         /// <returns>The logged in user.</returns>
@@ -28,8 +28,12 @@ interface ILoginManager
         /// <inheritdoc/>
         ITask Logout(UriString hostAddress);
 
-        bool LoginWithToken(
-            UriString host,
-            string token);
+        /// <summary>
+        /// Attempts to log into a GitHub server with a token.
+        /// </summary>
+        /// <param name="host">The host.</param>
+        /// <param name="token">The token.</param>
+        /// <returns></returns>
+        bool LoginWithToken(UriString host, string token);
     }
 }

src/GitHub.Api/Authentication/Keychain.cs

@@ -133,8 +133,6 @@ private KeychainAdapter FindOrCreateAdapter(UriString host)
             KeychainAdapter value;
             if (!keychainAdapters.TryGetValue(host, out value))
             {
-                logger.Trace("Creating Adapter {0}", host);
-
                 value = new KeychainAdapter();
                 keychainAdapters.Add(host, value);
             }

src/GitHub.Api/Authentication/LoginManager.cs

@@ -45,9 +45,7 @@ public LoginManager(
             this.environment = environment;
         }
 
-        public bool LoginWithToken(
-            UriString host,
-            string token)
+        public bool LoginWithToken(UriString host, string token)
         {
             Guard.ArgumentNotNull(host, nameof(host));
             Guard.ArgumentNotNullOrWhiteSpace(token, nameof(token));

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/Window.cs

@@ -2,7 +2,6 @@
 using System.Linq;
 using UnityEditor;
 using UnityEngine;
-using Object = System.Object;
 
 namespace GitHub.Unity
 {