Capturing the situation where versions are not returned at all

Author: StanleyGoldman

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/GitPathView.cs

@@ -15,7 +15,9 @@ class GitPathView : Subview
         private const string BrowseButton = "...";
         private const string GitInstallBrowseTitle = "Select git binary";
         private const string ErrorInvalidPathMessage = "Invalid Path.";
-        private const string ErrorGettingSoftwareVersionMessage = "Error getting software versions.";
+        private const string ErrorValidatingGitPath = "Error validating Git Path.";
+        private const string ErrorGitNotFoundMessage = "Git not found.";
+        private const string ErrorGitLfsNotFoundMessage = "Git LFS not found.";
         private const string ErrorMinimumGitVersionMessageFormat = "Git version {0} found. Git version {1} is required.";
         private const string ErrorMinimumGitLfsVersionMessageFormat = "Git LFS version {0} found. Git LFS version {1} is required.";
 
@@ -220,8 +222,8 @@ private void ValidateAndSetGitInstallPath(string value)
                 {
                     if (!sucess)
                     {
-                        Logger.Trace(ErrorGettingSoftwareVersionMessage);
-                        gitVersionErrorMessage = ErrorGettingSoftwareVersionMessage;
+                        Logger.Trace(ErrorValidatingGitPath);
+                        gitVersionErrorMessage = ErrorValidatingGitPath;
                     }
                     else if (!result.IsValid)
                     {
@@ -232,21 +234,32 @@ private void ValidateAndSetGitInstallPath(string value)
 
                         var errorMessageStringBuilder = new StringBuilder();
 
-                        if (result.GitVersion < Constants.MinimumGitVersion)
+                        if (result.GitVersion == null)
                         {
-                            errorMessageStringBuilder.AppendFormat(ErrorMinimumGitVersionMessageFormat,
-                                result.GitVersion, Constants.MinimumGitVersion);
+                            errorMessageStringBuilder.Append(ErrorGitNotFoundMessage);
                         }
-
-                        if (result.GitLfsVersion < Constants.MinimumGitLfsVersion)
+                        else if (result.GitLfsVersion == null)
+                        {
+                            errorMessageStringBuilder.Append(ErrorGitLfsNotFoundMessage);
+                        }
+                        else
                         {
-                            if (errorMessageStringBuilder.Length > 0)
+                            if (result.GitVersion < Constants.MinimumGitVersion)
                             {
-                                errorMessageStringBuilder.Append(Environment.NewLine);
+                                errorMessageStringBuilder.AppendFormat(ErrorMinimumGitVersionMessageFormat,
+                                    result.GitVersion, Constants.MinimumGitVersion);
                             }
 
-                            errorMessageStringBuilder.AppendFormat(ErrorMinimumGitLfsVersionMessageFormat,
-                                result.GitLfsVersion, Constants.MinimumGitLfsVersion);
+                            if (result.GitLfsVersion < Constants.MinimumGitLfsVersion)
+                            {
+                                if (errorMessageStringBuilder.Length > 0)
+                                {
+                                    errorMessageStringBuilder.Append(Environment.NewLine);
+                                }
+
+                                errorMessageStringBuilder.AppendFormat(ErrorMinimumGitLfsVersionMessageFormat,
+                                    result.GitLfsVersion, Constants.MinimumGitLfsVersion);
+                            }
                         }
 
                         gitVersionErrorMessage = errorMessageStringBuilder.ToString();