Changing how InitProjectView updates itself

Author: StanleyGoldman

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/InitProjectView.cs

@@ -11,20 +11,10 @@ class InitProjectView : Subview
         private const string NoUserOrEmailError = "Name and email not set in git. Go into the settings tab and enter the missing information";
 
         [NonSerialized] private bool isBusy;
-
         [NonSerialized] private bool isUserDataPresent;
+        [NonSerialized] private bool hasCompletedInitialCheck;
         [NonSerialized] private bool userDataHasChanged;
 
-        public override void InitializeView(IView parent)
-        {
-            base.InitializeView(parent);
-
-            if (!string.IsNullOrEmpty(Environment.GitExecutablePath))
-            {
-                CheckForUser();
-            }
-        }
-
         public override void OnEnable()
         {
             base.OnEnable();
@@ -69,7 +59,7 @@ public override void OnGUI()
                 }
                 GUILayout.EndHorizontal();
 
-                if (!isUserDataPresent)
+                if (hasCompletedInitialCheck && !isUserDataPresent)
                 {
                     EditorGUILayout.Space();
                     EditorGUILayout.HelpBox(NoUserOrEmailError, MessageType.Error);
@@ -80,6 +70,12 @@ public override void OnGUI()
             GUILayout.EndVertical();
         }
 
+        public override void OnDataUpdate()
+        {
+            base.OnDataUpdate();
+            MaybeUpdateData();
+        }
+
         private void MaybeUpdateData()
         {
             if (userDataHasChanged)
@@ -91,6 +87,13 @@ private void MaybeUpdateData()
 
         private void CheckForUser()
         {
+            if (string.IsNullOrEmpty(Environment.GitExecutablePath))
+            {
+                Logger.Warning("No git exec cannot check for user");
+                return;
+            }
+
+            Logger.Trace("Checking for user");
             isBusy = true;
 
             GitClient.GetConfigUserAndEmail().FinallyInUI((success, ex, strings) => {
@@ -99,8 +102,9 @@ private void CheckForUser()
 
                 isBusy = false;
                 isUserDataPresent = success && !String.IsNullOrEmpty(username) && !String.IsNullOrEmpty(email);
+                hasCompletedInitialCheck = true;
 
-                Logger.Trace("Finally: {0}", isUserDataPresent);
+                Logger.Trace("User Present: {0}", isUserDataPresent);
 
                 Redraw();
             }).Start();