Removing virtual field - we should not call virtual methods on constructors

Author: StanleyGoldman

src/GitHub.Api/NewTaskSystem/TaskBase.cs

@@ -370,7 +370,7 @@ public override string ToString()
         public WaitHandle AsyncWaitHandle { get { return (Task as IAsyncResult).AsyncWaitHandle; } }
         public object AsyncState { get { return (Task as IAsyncResult).AsyncState; } }
         public bool CompletedSynchronously { get { return (Task as IAsyncResult).CompletedSynchronously; } }
-        public virtual string Name { get; set; }
+        public string Name { get; set; }
         public virtual TaskAffinity Affinity { get; set; }
         private ILogging logger;
         protected ILogging Logger { get { return logger = logger ?? Logging.GetLogger(GetType()); } }

src/GitHub.Api/Platform/FindExecTask.cs

@@ -5,12 +5,11 @@ namespace GitHub.Unity
     class FindExecTask : ProcessTask<NPath>
     {
         private readonly string arguments;
-        private readonly string name;
 
         public FindExecTask(string executable, CancellationToken token)
             : base(token, new FirstLineIsPathOutputProcessor())
         {
-            Name = name = DefaultEnvironment.OnWindows ? "where" : "which";
+            Name = DefaultEnvironment.OnWindows ? "where" : "which";
             arguments = executable;
         }
 

src/UnityExtension/Assets/Editor/GitHub.Unity/Tasks/EvaluateProjectConfigurationTask.cs

@@ -321,7 +321,7 @@ private IEnumerable<ProjectConfigurationIssue> EvaluateGitIgnore()
             }
         }
 
-        public override string Name { get { return "Project Evaluation"; } }
+        public string Name { get { return "Project Evaluation"; } }
 
         private enum SerializationSetting
         {