Fix pull button behaviour

We need to track git status data changes in order to allow/disallow a pull, since the filesystem may have uncommited changes at any time

Author: shana

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/ChangesView.cs

@@ -18,9 +18,9 @@ class ChangesView : Subview
         private const string OneChangedFileLabel = "1 changed file";
         private const string NoChangedFilesLabel = "No changed files";
 
-        [NonSerialized] private bool currentBranchHasUpdate;
-        [NonSerialized] private bool currentStatusEntriesHasUpdate;
-        [NonSerialized] private bool currentLocksHasUpdate;
+        [SerializeField] private bool currentBranchHasUpdate;
+        [SerializeField] private bool currentStatusEntriesHasUpdate;
+        [SerializeField] private bool currentLocksHasUpdate;
 
         [NonSerialized] private GUIContent discardGuiContent;
 

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/HistoryView.cs

@@ -308,8 +308,8 @@ class HistoryView : Subview
         private const string CommitDetailsTitle = "Commit details";
         private const string ClearSelectionButton = "×";
 
-        [NonSerialized] private bool currentLogHasUpdate;
-        [NonSerialized] private bool currentTrackingStatusHasUpdate;
+        [SerializeField] private bool currentLogHasUpdate;
+        [SerializeField] private bool currentTrackingStatusHasUpdate;
 
         [SerializeField] private HistoryControl historyControl;
         [SerializeField] private GitLogEntry selectedEntry = GitLogEntry.Default;

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/Window.cs

@@ -13,15 +13,16 @@ class Window : BaseWindow
         private const string Menu_Window_GitHub = "Window/GitHub";
         private const string Menu_Window_GitHub_Command_Line = "Window/GitHub Command Line";
 
-        [NonSerialized] private bool currentBranchAndRemoteHasUpdate;
-        [NonSerialized] private bool currentTrackingStatusHasUpdate;
         [NonSerialized] private double notificationClearTime = -1;
         [NonSerialized] private double timeSinceLastRotation = -1f;
         [NonSerialized] private Spinner spinner;
         [NonSerialized] private IProgress progress;
         [NonSerialized] private float progressValue;
         [NonSerialized] private string progressMessage;
 
+        [SerializeField] private bool currentBranchAndRemoteHasUpdate;
+        [SerializeField] private bool currentTrackingStatusHasUpdate;
+        [SerializeField] private bool currentStatusEntriesHasUpdate;
         [SerializeField] private SubTab changeTab = SubTab.InitProject;
         [SerializeField] private SubTab activeTab = SubTab.InitProject;
         [SerializeField] private InitProjectView initProjectView = new InitProjectView();
@@ -40,6 +41,7 @@ class Window : BaseWindow
         [SerializeField] private GUIContent currentRemoteUrlContent;
         [SerializeField] private CacheUpdateEvent lastCurrentBranchAndRemoteChangedEvent;
         [SerializeField] private CacheUpdateEvent lastTrackingStatusChangedEvent;
+        [SerializeField] private CacheUpdateEvent lastStatusEntriesChangedEvent;
 
         [MenuItem(Menu_Window_GitHub)]
         public static void Window_GitHub()
@@ -271,13 +273,16 @@ private void MaybeUpdateData()
             if (currentTrackingStatusHasUpdate)
             {
                 currentTrackingStatusHasUpdate = false;
-
                 statusAhead = Repository.CurrentAhead;
                 statusBehind = Repository.CurrentBehind;
+            }
 
+            if (currentStatusEntriesHasUpdate)
+            {
+                currentStatusEntriesHasUpdate = false;
                 var currentChanges = Repository.CurrentChanges;
-                hasItemsToCommit = currentChanges != null
-                    && currentChanges.Any(entry => entry.Status != GitFileStatus.Ignored && !entry.Staged);
+                hasItemsToCommit = currentChanges != null &&
+                    currentChanges.Any(entry => entry.Status != GitFileStatus.Ignored && !entry.Staged);
             }
 
             if (currentBranchAndRemoteHasUpdate)
@@ -366,6 +371,7 @@ private void AttachHandlers(IRepository repository)
                 return;
             repository.CurrentBranchAndRemoteChanged += RepositoryOnCurrentBranchAndRemoteChanged;
             repository.TrackingStatusChanged += RepositoryOnTrackingStatusChanged;
+            repository.StatusEntriesChanged += RepositoryOnStatusEntriesChanged;
         }
 
         private void RepositoryOnCurrentBranchAndRemoteChanged(CacheUpdateEvent cacheUpdateEvent)
@@ -388,6 +394,16 @@ private void RepositoryOnTrackingStatusChanged(CacheUpdateEvent cacheUpdateEvent
             }
         }
 
+        private void RepositoryOnStatusEntriesChanged(CacheUpdateEvent cacheUpdateEvent)
+        {
+            if (!lastStatusEntriesChangedEvent.Equals(cacheUpdateEvent))
+            {
+                lastStatusEntriesChangedEvent = cacheUpdateEvent;
+                currentStatusEntriesHasUpdate = true;
+                Redraw();
+            }
+        }
+
         private void OnProgress(IProgress progr)
         {
             progress = progr;
@@ -399,6 +415,7 @@ private void DetachHandlers(IRepository repository)
                 return;
             repository.CurrentBranchAndRemoteChanged -= RepositoryOnCurrentBranchAndRemoteChanged;
             repository.TrackingStatusChanged -= RepositoryOnTrackingStatusChanged;
+            repository.StatusEntriesChanged -= RepositoryOnStatusEntriesChanged;
         }
 
         private void DoHeaderGUI()