Merge pull request #680 from github-for-unity/fixes/using-system-git-is-borked

Fixes UI unavailable when using the system git

Author: shana

src/GitHub.Api/Application/ApplicationManagerBase.cs

@@ -99,7 +99,10 @@ public void Run(bool firstRun)
             {
                 if (path.IsInitialized)
                 {
-                    var state = new GitInstaller.GitInstallationState { GitExecutablePath = path };
+                    var state = new GitInstaller.GitInstallationState {
+                        GitExecutablePath = path,
+                        GitIsValid = true
+                    };
                     endTask.PreviousResult = state;
                     endTask.Start();
                     return;

src/GitHub.Api/OutputProcessors/ProcessManager.cs

@@ -30,18 +30,7 @@ public T Configure<T>(T processTask, NPath? executable = null, string arguments
             bool dontSetupGit = false)
              where T : IProcess
         {
-            if (executable == null)
-            {
-                if (processTask.ProcessName?.ToNPath() != null)
-                {
-                    executable = processTask.ProcessName.ToNPath();
-                }
-                else
-                {
-                    executable = environment.GitExecutablePath;
-                    dontSetupGit = environment.IsCustomGitExecutable;
-                }
-            }
+            executable = executable ?? processTask.ProcessName?.ToNPath() ?? environment.GitExecutablePath;
 
             //If this null check fails, be sure you called Configure() on your task
             Guard.ArgumentNotNull(executable, nameof(executable));