Merge branch 'master' into add-that-editorconfig-thing

Author: StanleyGoldman

README.md

@@ -47,8 +47,8 @@ The GitHub for Unity extension brings [Git](https://git-scm.com/) and GitHub int
 
 ### Requirements
 
-- Unity 5.4-2017.1
-   - We've only tested the extension so far on Unity 5.4 to 2017.1. There's currently an blocker issue opened for 5.3 support, so we know it doesn't run there. There are some issues for 2017.2, so it may or may not run well on that version. Personal edition is fine.
+- Unity 5.4 or higher
+   - There's currently an blocker issue opened for 5.3 support, so we know it doesn't run there. Personal edition is fine.
 - Git and Git LFS 2.x
 
 #### Git on macOS

common/codeanalysis-debug.ruleset

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
-<RuleSet Name="codeanalysis-small" Description="This ruleset only includes the rules we care about. I'll be adding new ones as we fix our codebase." ToolsVersion="14.0">
+<RuleSet Name="codeanalysis-debug" Description="This ruleset only includes the rules we care about. I'll be adding new ones as we fix our codebase." ToolsVersion="14.0">
   <IncludeAll Action="Warning" />
   <Rules AnalyzerId="Microsoft.Analyzers.ManagedCodeAnalysis" RuleNamespace="Microsoft.Rules.Managed">
     <Rule Id="CA1000" Action="None" />
@@ -86,7 +86,6 @@
     <Rule Id="CA1308" Action="None" />
     <Rule Id="CA1309" Action="None" />
     <Rule Id="CA1820" Action="None" />
-    <Rule Id="CA1823" Action="None" />
 
     <!-- serialization -->
     <Rule Id="CA2237" Action="None" />