Merge pull request #232 from github-for-unity/fixes/history-view-repository-manager

Using Repository.Log from HistoryView

Author: StanleyGoldman

src/GitHub.Api/Git/IRepository.cs

@@ -11,6 +11,7 @@ interface IRepository : IEquatable<IRepository>
         void Initialize(IRepositoryManager repositoryManager);
         void Refresh();
         ITask SetupRemote(string remoteName, string remoteUrl);
+        ITask<List<GitLogEntry>> Log();
         ITask Pull();
         ITask Push();
         ITask Fetch();

src/GitHub.Api/Git/Repository.cs

@@ -3,6 +3,7 @@
 using System.Diagnostics;
 using System.Globalization;
 using System.Linq;
+using System.Threading;
 
 namespace GitHub.Unity
 {
@@ -78,6 +79,14 @@ public ITask SetupRemote(string remote, string remoteUrl)
             }
         }
 
+        public ITask<List<GitLogEntry>> Log()
+        {
+            if (repositoryManager == null)
+                return new FuncListTask<GitLogEntry>(TaskHelpers.GetCompletedTask(new List<GitLogEntry>()));
+
+            return repositoryManager.Log();
+        }
+
         public ITask Pull()
         {
             return repositoryManager.Pull(CurrentRemote.Value.Name, CurrentBranch?.Name);

src/GitHub.Api/Git/RepositoryManager.cs

@@ -29,6 +29,7 @@ interface IRepositoryManager : IDisposable
         void Stop();
         void Refresh();
         ITask CommitFiles(List<string> files, string message, string body);
+        ITask<List<GitLogEntry>> Log();
         ITask Fetch(string remote);
         ITask Pull(string remote, string branch);
         ITask Push(string remote, string branch);
@@ -200,6 +201,13 @@ public ITask CommitFiles(List<string> files, string message, string body)
                 .Finally(() => IsBusy = false);
         }
 
+        public ITask<List<GitLogEntry>> Log()
+        {
+            var task = GitClient.Log();
+            HookupHandlers(task);
+            return task;
+        }
+
         public ITask Fetch(string remote)
         {
             var task = GitClient.Fetch(remote);

src/GitHub.Api/GitHub.Api.csproj

@@ -109,6 +109,7 @@
     <Compile Include="Helpers\Constants.cs" />
     <Compile Include="Cache\IBranchCache.cs" />
     <Compile Include="Helpers\Validation.cs" />
+    <Compile Include="Helpers\TaskHelpers.cs" />
     <Compile Include="Platform\DefaultEnvironment.cs" />
     <Compile Include="Extensions\EnvironmentExtensions.cs" />
     <Compile Include="Extensions\FileEventExtensions.cs" />

src/GitHub.Api/Helpers/TaskHelpers.cs

@@ -0,0 +1,12 @@
+using System.Threading.Tasks;
+
+namespace GitHub.Unity
+{
+    static class TaskHelpers
+    {
+        public static Task<T> GetCompletedTask<T>(T result)
+        {
+            return TaskEx.FromResult(result);
+        }
+    }
+}

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/HistoryView.cs

@@ -203,14 +203,11 @@ private void UpdateStatus(GitStatus status)
 
         private void RefreshLog()
         {
-            if (GitClient != null)
+            if (Repository != null)
             {
-                if (Repository != null)
-                {
-                    GitClient.Log().ThenInUI((success, log) => {
-                        if (success) OnLogUpdate(log);
-                    }).Start();
-                }
+                Repository.Log().ThenInUI((success, log) => {
+                    if (success) OnLogUpdate(log);
+                }).Start();
             }
         }