Merge branch '1.0rc/master' into 1.0rc/fixes/dispose-of-things

Author: shana

src/GitHub.Api/Application/ApplicationManagerBase.cs

@@ -56,7 +56,7 @@ public void Run(bool firstRun)
             Logger.Trace("Run - CurrentDirectory {0}", NPath.CurrentDirectory);
 
             var gitExecutablePath = SystemSettings.Get(Constants.GitInstallPathKey)?.ToNPath();
-            if (gitExecutablePath != null && gitExecutablePath.Value.FileExists()) // we have a git path
+            if (gitExecutablePath.HasValue && gitExecutablePath.Value.FileExists()) // we have a git path
             {
                 Logger.Trace("Using git install path from settings: {0}", gitExecutablePath);
                 InitializeEnvironment(gitExecutablePath.Value);
@@ -71,7 +71,7 @@ public void Run(bool firstRun)
                 var findExecTask = new FindExecTask("git", CancellationToken)
                     .FinallyInUI((b, ex, path) =>
                     {
-                        if (b && path != null)
+                        if (b && path.IsInitialized)
                         {
                             //Logger.Trace("FindExecTask Success: {0}", path);
                             InitializeEnvironment(path);
@@ -144,7 +144,7 @@ public ITask InitializeRepository()
 
         public void RestartRepository()
         {
-            if (Environment.RepositoryPath != null)
+            if (Environment.RepositoryPath.IsInitialized)
             {
                 repositoryManager = Unity.RepositoryManager.CreateInstance(Platform, TaskManager, GitClient, Environment.FileSystem, Environment.RepositoryPath);
                 repositoryManager.Initialize();

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/GitPathView.cs

@@ -35,7 +35,7 @@ class GitPathView : Subview
         public override void InitializeView(IView parent)
         {
             base.InitializeView(parent);
-            gitExecutableIsSet = Environment.GitExecutablePath != null;
+            gitExecutableIsSet = Environment.GitExecutablePath.IsInitialized;
         }
 
         public override void OnEnable()
@@ -181,7 +181,7 @@ private void MaybeUpdateData()
                     }
                 }
 
-                if (Environment.GitExecutablePath != null)
+                if (Environment.GitExecutablePath.IsInitialized)
                 {
                     newGitExec = gitExec = Environment.GitExecutablePath.ToString();
                     gitExecParent = Environment.GitExecutablePath.Parent.ToString();

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/InitProjectView.cs

@@ -22,7 +22,7 @@ class InitProjectView : Subview
         public override void InitializeView(IView parent)
         {
             base.InitializeView(parent);
-            gitExecutableIsSet = Environment.GitExecutablePath != null;
+            gitExecutableIsSet = Environment.GitExecutablePath.IsInitialized;
             Redraw();
         }
 

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/UserSettingsView.cs

@@ -26,7 +26,7 @@ class UserSettingsView : Subview
         public override void InitializeView(IView parent)
         {
             base.InitializeView(parent);
-            gitExecutableIsSet = Environment.GitExecutablePath != null;
+            gitExecutableIsSet = Environment.GitExecutablePath.IsInitialized;
         }
 
         public override void OnDataUpdate()