Some git processes return 1 on success, sigh

shana · shana · commit 07d54d8daf2f · 2017-06-27T21:46:36.000+02:00
diff --git a/src/GitHub.Api/NewTaskSystem/ProcessTask.cs b/src/GitHub.Api/NewTaskSystem/ProcessTask.cs
@@ -156,7 +156,7 @@ public void Run()
                     }
                 }
 
-                if (Process.ExitCode != 0)
+                if (Process.ExitCode != 0 && errors.Count > 0)
                 {
                     onError?.Invoke(null, String.Join(Environment.NewLine, errors.ToArray()));
                 }

Original file line number	Diff line number	Diff line change
`@@ -156,7 +156,7 @@ public void Run()`
`156`	`156`	`}`
`157`	`157`	`}`
`158`	`158`
`159`		`- if (Process.ExitCode != 0)`
	`159`	`+ if (Process.ExitCode != 0 && errors.Count > 0)`
`160`	`160`	`{`
`161`	`161`	`onError?.Invoke(null, String.Join(Environment.NewLine, errors.ToArray()));`
`162`	`162`	`}`