Merge pull request #813 from github-for-unity/fixes/locks-in-usage-tracker

Adding locking to the UsageTracker

Author: shana

script

@@ -8,6 +8,6 @@ public interface IMetricsService
         /// <summary>
         /// Posts the provided usage model.
         /// </summary>
-        Task PostUsage(List<Usage> model);
+        void PostUsage(List<Usage> model);
     }
 }

src/GitHub.Api/Metrics/IMetricsService.cs

@@ -85,18 +85,18 @@ public Usage GetCurrentUsage(string appVersion, string unityVersion, string inst
 
         public List<Usage> SelectReports(DateTime beforeDate)
         {
-            return Reports.Where(usage => usage.Dimensions.Date.Date != beforeDate.Date).ToList();
+            return Reports.Where(usage => usage.Dimensions.Date.Date < beforeDate.Date).ToList();
         }
 
         public void RemoveReports(DateTime beforeDate)
         {
-            Reports.RemoveAll(usage => usage.Dimensions.Date.Date != beforeDate.Date);
+            Reports.RemoveAll(usage => usage.Dimensions.Date.Date < beforeDate.Date);
         }
     }
 
     class UsageStore
     {
-        public DateTimeOffset LastUpdated { get; set; } = DateTimeOffset.Now;
+        public DateTimeOffset LastSubmissionDate { get; set; } = DateTimeOffset.Now;
         public UsageModel Model { get; set; } = new UsageModel();
 
         public Measures GetCurrentMeasures(string appVersion, string unityVersion, string instanceId)