-
Notifications
You must be signed in to change notification settings - Fork 692
feat: Add feature to enable dynamic instance types via workflow labels #4529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@npalm can you revisit? This feature is a great addition to the project |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions. |
due to lack of time, it is still in this state. @edersonbrilhante let me know if you have interest to collaborate on the feature. Feel free to DM me on discord. |
|
I have interest in help with this feature. We could extend this to AMI name, ami owner, ami kms key, volume, etc. |
|
created a thread on discord to discuss the PR and directions: |

Description
This PR adds an option to define the required instance type via the workflow labels. This could be all tricky, since in the end GH decides which workflo runs on a runner.
By adding a label to the workflow starting with
ghr-ec2-and followed by the instance type a runenr for the required instance type is caled (only if the teature is enabled).For example:

ghr-ec2-m5.xlargeLimitiation
Status
Early draft, just a POC, no tests, no docs, requires rerfactoing.
Todo