CIHelper: allow specifying the information to send emails

One of the primary goals of GitGitGadget is to send emails. So far, the
configuration for sending those is provided via environment variables or
via the Git config. This is _implicit_, and I want to make this
_explicit_ in preparation for the upcoming conversion to a set of GitHub
Actions.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

Author: dscho

lib/ci-helper.ts

@@ -14,6 +14,7 @@ import { IMailMetadata } from "./mail-metadata.js";
 import { IPatchSeriesMetadata } from "./patch-series-metadata.js";
 import { IConfig, getExternalConfig, setConfig } from "./project-config.js";
 import { getPullRequestKeyFromURL, pullRequestKey } from "./pullRequestKey.js";
+import { ISMTPOptions } from "./send-mail.js";
 
 const readFile = util.promisify(fs.readFile);
 type CommentFunction = (comment: string) => Promise<void>;
@@ -39,6 +40,7 @@ export class CIHelper {
     private gggNotesUpdated: boolean;
     private mail2CommitMapUpdated: boolean;
     private notesPushToken: string | undefined;
+    private smtpOptions?: ISMTPOptions;
     protected maxCommitsExceptions: string[];
 
     public static async getConfig(configFile?: string): Promise<IConfig> {
@@ -67,6 +69,10 @@ export class CIHelper {
         }
     }
 
+    public setSMTPOptions(smtpOptions: ISMTPOptions): void {
+        this.smtpOptions = smtpOptions;
+    }
+
     /*
      * Given a commit that was contributed as a patch via GitGitGadget (i.e.
      * a commit with a Message-ID recorded in `refs/notes/gitgitgadget`),
@@ -587,6 +593,7 @@ export class CIHelper {
                 this.workDir,
                 this.urlRepo,
                 this.notesPushToken,
+                this.smtpOptions,
             );
             if (!gitGitGadget.isUserAllowed(comment.author)) {
                 throw new Error(`User ${comment.author} is not yet permitted to use ${this.config.app.displayName}`);
@@ -793,7 +800,13 @@ export class CIHelper {
             await this.github.addPRComment(prKey, redacted);
         };
 
-        const gitGitGadget = await GitGitGadget.get(this.gggConfigDir, this.workDir, this.urlRepo, this.notesPushToken);
+        const gitGitGadget = await GitGitGadget.get(
+            this.gggConfigDir,
+            this.workDir,
+            this.urlRepo,
+            this.notesPushToken,
+            this.smtpOptions,
+        );
         if (!pr.hasComments && !gitGitGadget.isUserAllowed(pr.author)) {
             const welcome = (await readFile("res/WELCOME.md")).toString().replace(/\${username}/g, pr.author);
             await this.github.addPRComment(prKey, welcome);

lib/gitgitgadget.ts

@@ -41,6 +41,7 @@ export class GitGitGadget {
         workDir?: string,
         publishTagsAndNotesToRemote?: string,
         notesPushToken?: string,
+        smtpOptions?: ISMTPOptions,
     ): Promise<GitGitGadget> {
         if (!workDir) {
             workDir = await this.getWorkDir(gitGitGadgetDir);
@@ -64,25 +65,21 @@ export class GitGitGadget {
 
         const notes = new GitNotes(workDir);
 
-        const smtpUser = await getVar("smtpUser", gitGitGadgetDir);
-        const smtpHost = await getVar("smtpHost", gitGitGadgetDir);
-        const smtpPass = await getVar("smtpPass", gitGitGadgetDir);
-        const smtpOpts = await getVar("smtpOpts", gitGitGadgetDir);
+        if (!smtpOptions) {
+            const smtpUser = await getVar("smtpUser", gitGitGadgetDir);
+            const smtpHost = await getVar("smtpHost", gitGitGadgetDir);
+            const smtpPass = await getVar("smtpPass", gitGitGadgetDir);
+            const smtpOpts = await getVar("smtpOpts", gitGitGadgetDir);
 
-        if (!smtpUser || !smtpHost || !smtpPass) {
-            throw new Error("No SMTP settings configured");
+            if (!smtpUser || !smtpHost || !smtpPass) {
+                throw new Error("No SMTP settings configured");
+            }
+            smtpOptions = { smtpHost, smtpOpts, smtpPass, smtpUser };
         }
 
         const [options, allowedUsers] = await GitGitGadget.readOptions(notes);
 
-        return new GitGitGadget(
-            notes,
-            options,
-            allowedUsers,
-            { smtpHost, smtpOpts, smtpPass, smtpUser },
-            publishTagsAndNotesToRemote,
-            notesPushToken,
-        );
+        return new GitGitGadget(notes, options, allowedUsers, smtpOptions, publishTagsAndNotesToRemote, notesPushToken);
     }
 
     protected static async readOptions(notes: GitNotes): Promise<[IGitGitGadgetOptions, Set<string>]> {