Implement global search#24
Open
Duhl-Liamz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3
Implements a focused global search feature for the
$5issue.Summary
GET /api/v1/search/for resources visible to the current usercountWhy this version
This takes the same basic direction as the existing open PR, but addresses the review concerns up front:
countrepresent all matching records, not just the returned pageVerification
python -m compileall backend\apppython -m alembic upgrade headpython -m pytest app\tests\api\routes\test_search.py -q(4 passed)python -m pytest app\tests -q -k "not test_reset_password and not pre_start"(55 passed, 4 deselected)python -m ruff check appnpm cinpm run buildbiome check --no-errors-on-unmatched --files-ignore-unknown=true src\components\Common\Navbar.tsxLocal setup used portable PostgreSQL 16 on
localhost:5432plus portable Node.js 20/npm for the frontend build.Note: the unfiltered backend suite currently has unrelated baseline failures:
test_reset_passwordchanges the superuser password without restoring it, and two pre-start tests usecalled_once_withinstead ofassert_called_once_with.