Implement exercise T6L1/branch-previous #125
Conversation
branch_previous/tests/specs/base.yml
Outdated
| initialization: | ||
| steps: | ||
| - type: bash | ||
| runs: echo "It was a dark and stormy night." > story.txt |
There was a problem hiding this comment.
Note for all repo-smith spec files, but please use the semantic types provided rather than reaching for bash every time.
echo->new-filegit checkout->checkout
There was a problem hiding this comment.
Left the checkout commands as they are for now due to the need for the HEAD~1 parameter
branch_previous/tests/specs/base.yml
Outdated
| empty: false | ||
| - type: bash | ||
| runs: | | ||
| git checkout -b visitor-line HEAD~1 |
There was a problem hiding this comment.
For these types of commits, can you explain why you need to base them off of HEAD~1?
There was a problem hiding this comment.
Okay I see the point. I will include an additional parameter to repo-smith to support this
branch_previous/verify.py
Outdated
| ) | ||
|
|
||
|
|
||
| def get_commit_from_message(exercise: GitAutograderExercise, message: str) -> Optional[GitAutograderCommit]: |
There was a problem hiding this comment.
This is similar to what I implemented, maybe I can extract this out to exercise_utils so that you can reuse it, but will need to wait and see which one gets merged first. Need to check first whether exercise_utils can be used under verify.py first, as it might not be loaded into the namespace.
Update: verify.py cannot use util functions from exercise_utils, thus we can stick with this implemetation.
| - type: commit | ||
| message: Mention noise | ||
| empty: false | ||
| - type: bash |
There was a problem hiding this comment.
I have also implemented the support for start-point in repo-smith, so we can wait for it to get merged.
3 participants
Exercise Review
Exercise Discussion
Fixes #65
Checklist
Git-Masteryorganization, have you created a request for it?repo-smithto validate the exercise grading scheme?test-download.sh?git-autograder?app?