Implement T6L2 merge undo #120
Conversation
woojiahao
left a comment
woojiahao
left a comment
There was a problem hiding this comment.
The autograding and unit testing LGTM! Just comments on the download itself. Thank you!
merge_undo/res/README.md
Outdated
There was a problem hiding this comment.
This does not need to be a res/ file! The app automatically pulls the README.md
merge_undo/download.py
Outdated
|
|
||
|
|
||
| def setup(verbose: bool = False): | ||
| create_start_tag(verbose) |
There was a problem hiding this comment.
I don't think this is necessary
There was a problem hiding this comment.
Ah, I just assumed since some other exercises implemented this as well, I would too. Apologies will fix.
merge_undo/download.py
Outdated
| create_start_tag(verbose) | ||
|
|
||
| # main branch | ||
| checkout("main", False, verbose) |
There was a problem hiding this comment.
| checkout("main", False, verbose) |
Not necessary. The default branch should always be main
|
Hi @kea-S , is this PR currently being worked on? Would be good to get an update by 9 Dec, else we need to close this PR, so that we can resolve this issue. Thanks! |
Apologies, Just saw this message today, I've made the changes as requested but would like to point out that my test-downloads.sh doesn't work anymore since removing the res/README.md file. |
3 participants
Exercise Review
merge-undo
Exercise Discussion
#67
Checklist
Git-Masteryorganization, have you created a request for it?repo-smithto validate the exercise grading scheme?test-download.sh?git-autograder?app?