"Downgrade" to node.js v12.x

dscho · dscho · commit 2eb80f1f94be · 2021-10-11T15:54:48.000+02:00
GitHub Actions run on node.js v12.x, therefore we cannot use any newer
features. This lead to an error in a recent upgrade when trying to
unpack and download the full SDK:

	TypeError: fs_1.default.promises.rm is not a function

By fixing @types/node to a version compatible with node.js v12.x we will
avoid this issue in the future.

Signed-off-by: Johannes Schindelin &lt;johannes.schindelin@gmx.de&gt;
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -35,7 +35,7 @@
   },
   "devDependencies": {
     "@types/jest": "^27.0.2",
-    "@types/node": "^16.10.3",
+    "@types/node": "^12.12.6",
     "@types/unzipper": "^0.10.4",
     "@typescript-eslint/parser": "^4.33.0",
     "@vercel/ncc": "^0.31.1",
diff --git a/src/downloader.ts b/src/downloader.ts
@@ -178,7 +178,8 @@ async function unpackTarXZInZipFromURL(
       }
     })
   })
-  await fs.promises.rm(tmp, {recursive: true})
+  await fs.promises.unlink(zipPath)
+  await fs.promises.rmdir(tmp)
 }
 
 export async function get(

Original file line number	Diff line number	Diff line change
`@@ -178,7 +178,8 @@ async function unpackTarXZInZipFromURL(`
`178`	`178`	`}`
`179`	`179`	`})`
`180`	`180`	`})`
`181`		`- await fs.promises.rm(tmp, {recursive: true})`
	`181`	`+ await fs.promises.unlink(zipPath)`
	`182`	`+ await fs.promises.rmdir(tmp)`
`182`	`183`	`}`
`183`	`184`
`184`	`185`	`export async function get(`