Skip to content

Commit beb7b83

Browse files
committed
fix: resolve release-please workspace member detection
- Remove explicit '.' from Cargo workspace members — root package is implicit when [workspace] and [package] coexist in the same manifest. release-please's cargo-workspace plugin was warning 'member . declared but did not find Cargo.toml', causing git-rewrite's [package].version to not be written to Cargo.toml in release PRs. - Remove redundant extra-files block for plumbing/git-filter-tree. The path '/Cargo.toml' had a spurious leading slash, and the update it was trying to make (dependencies.git-filter-tree.version) is already handled automatically by the cargo-workspace plugin.
1 parent 9fe8cbd commit beb7b83

2 files changed

Lines changed: 2 additions & 10 deletions

File tree

.config/release-please-config.json

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,15 +14,7 @@
1414
"include-component-in-tag": false,
1515
"exclude-paths": ["plumbing/"]
1616
},
17-
"plumbing/git-filter-tree": {
18-
"extra-files": [
19-
{
20-
"type": "toml",
21-
"path": "/Cargo.toml",
22-
"jsonpath": "$.dependencies.git-filter-tree.version"
23-
}
24-
]
25-
}
17+
"plumbing/git-filter-tree": {}
2618
},
2719
"plugins": [{ "type": "sentence-case" }, { "type": "cargo-workspace" }],
2820
"$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json"

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[workspace]
22
resolver = "3"
3-
members = [".", "plumbing/git-filter-tree"]
3+
members = ["plumbing/git-filter-tree"]
44

55
[workspace.package]
66
edition = "2024"

0 commit comments

Comments
 (0)