Tab with file:/// URL breaks Tabox Open collection function

[Levertraan]

Any tab with file:/// URL breaks Tabox Open collection function.
It skips those file:/// tabs (or cannot open them if (Discard tabs on open(Enabled))
Often this leads to groups being wholly or partially absent from the collection.
Generally http:// tabs will be present, but may be ungrouped.
Behaviour is not consistent; seems to truncate processing of collection on opening, particularly groups.

[SohamBiswas2007]

I tried it on Discard tabs on open(Disabled). I beleive a part of the problem is due to incorrect processing of URL. The extension adds an "&favicon=" at the end which may play a part in breaking the feature.

[kyletimmermans]

@Levertraan
@SohamBiswas2007 I thought the same thing, that by removing "&favicon=", would fix the issue. And it makes sense, because if you were to add that string to the end of any file:/// url, that would break it.

However, when we see the "&favicon=" in the url, this is actually only present for tabox's "Redirecting" page, the favicon string is only temporarily being stored there. The actual redirect removes the "&favicon=" string before the page is loaded (the file:/// URL).

The issue is that the "Redirecting" page doesn't have permission to open local file URLs, if you open the JavaScript console on that page for a file:/// URL, you'll see a "Not allowed to load local resource" error, and I believe this is the reason for the issues with any file:/// tabs.

I put in a PR to fix the issue: #71

[gil-wix]

Apologies it took so long for me to respond!
First, thank you for reporting the issue and thanks @kyletimmermans for submitting a PR!
Second, I have a fix for this and also tabs that start with chrome:// and about: - this will be published soon with a brand new version of Tabox (v4.0) which includes a lot of cool new stuff.
Apologies again for the issue and the delay in responding.

[kyletimmermans]

No worries! Looking forward to v4.0!