Skip to content

Commit db81d5e

Browse files
authored
model-conversion : use CONVERTED_EMBEDDING_MODEL for embedding_verify_logits (#18079)
This commit updates the embedding model verification script to use the CONVERTED_EMBEDDING_MODEL environment variable instead of using the EMBEDDING_MODEL_PATH (the original embedding model path) as the basis for the converted model file name. The motivation for this that currently if the converted embedding model file name differs from the original embedding model directory/name the verification script will look for the wrong .bin files that were generating when running the models.
1 parent c05aa69 commit db81d5e

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

examples/model-conversion/scripts/embedding/compare-embeddings-logits.sh

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,11 @@ done
3434
MODEL_PATH="${MODEL_PATH:-"$EMBEDDING_MODEL_PATH"}"
3535
MODEL_NAME="${MODEL_NAME:-$(basename "$MODEL_PATH")}"
3636

37+
CONVERTED_MODEL_PATH="${CONVERTED_EMBEDDING_PATH:-"$CONVERTED_EMBEDDING_MODEL"}"
38+
CONVERTED_MODEL_NAME="${CONVERTED_MODEL_NAME:-$(basename "$CONVERTED_MODEL_PATH" .gguf)}"
39+
3740
if [ -t 0 ]; then
38-
CPP_EMBEDDINGS="data/llamacpp-${MODEL_NAME}-embeddings.bin"
41+
CPP_EMBEDDINGS="data/llamacpp-${CONVERTED_MODEL_NAME}-embeddings.bin"
3942
else
4043
# Process piped JSON data and convert to binary (matching logits.cpp format)
4144
TEMP_FILE=$(mktemp /tmp/tmp.XXXXXX.binn)

0 commit comments

Comments
 (0)