feat(trace-tree-node): Mitigating txn node type guards usage #104498
+2
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Abdkhan14
commented
Dec 9, 2025
| color: colors[1], | ||
| }; | ||
|
|
||
| if (isTransactionNode(node)) { |
Contributor
Author
There was a problem hiding this comment.
No need to look for 'transaction.op' specifically in value, we can use the baseNode.op getter
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| nodeInfo.color = colors[4]; | ||
| } else { | ||
| nodeInfo.subtitle = node.value.description || ''; | ||
| nodeInfo.subtitle = node.description || ''; |
Contributor
There was a problem hiding this comment.
Bug: TransactionNode title and subtitle are swapped after change
Removing the isTransactionNode check and early return causes TransactionNode types that don't match any AI-specific conditions to have their title and subtitle swapped. Previously, TransactionNode displayed the transaction name (e.g., "POST /api/endpoint") as the title and the operation as the subtitle. Now, for these nodes, title is set to truncatedOp (the operation) and subtitle is set to node.description (the transaction name via the TransactionNode.description getter), reversing the original display order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.