Skip to content

feat(trace-tree-node): Mitigating eap span node type guards usage #104497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Abdkhan14 wants to merge 2 commits into
base: abdk/trace-tree-node-span-node-guards
Choose a base branch
from
Open

feat(trace-tree-node): Mitigating eap span node type guards usage #104497

Abdkhan14 wants to merge 2 commits into from
+25 −49

Conversation

@Abdkhan14
Copy link
Contributor

@Abdkhan14 Abdkhan14 commented Dec 6, 2025 •
edited
Loading

  • Added an attributes getter to the baseNode class, used it to get rid of some guards
  • Removed isEapTransaction, reduces guards count. guards, we can check for an eapSpanNode with value.is_transaction=true

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Dec 6, 2025
@Abdkhan14 Abdkhan14 marked this pull request as ready for review December 9, 2025 01:16
@Abdkhan14 Abdkhan14 requested a review from a team as a code owner December 9, 2025 01:16
@Abdkhan14 Abdkhan14 requested a review from gggritso December 9, 2025 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gggritso gggritso Awaiting requested review from gggritso

1 more reviewer

@sentry sentry[bot] sentry[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Abdkhan14