fix(dashboards): temporary filters broken when changing values

[DominikB2014]

1. Add ability to disable removeFilter option, this is currently done when the dashboard is prebuilt, and a filter exists in it's prebuilt config.
2. remove the temporaryFilters query param and add isTemporary property to GlobalFilters which is easier to manage then having two separate query params
3. Add tests cases to dashboard link field renderer and filter bar

[linear]

BROWSE-177 Global filter change on Query Details page has no effect on displayed content

[Ahmed-Labs]

I tested global filters in non-prebuilt dashboards and it seems that unsaved changes don't get picked up (changes get pushed to url params but no save button pops up)

[DominikB2014]

I tested global filters in non-prebuilt dashboards and it seems that unsaved changes don't get picked up (changes get pushed to url params but no save button pops up)

👍 Thanks for testing! We should probs add some test cases here to prevent regressions

[sentry]

Bug: Missing validation for prebuiltDashboardId as a key in PREBUILT_DASHBOARDS can lead to runtime crash when accessing .filters.
_{Severity: CRITICAL | Confidence: High}

🔍 Detailed Analysis

The code at static/app/views/dashboards/filtersBar.tsx:73-75 accesses PREBUILT_DASHBOARDS[prebuiltDashboardId] without validating if prebuiltDashboardId is a valid key within PREBUILT_DASHBOARDS. This can lead to PREBUILT_DASHBOARDS[prebuiltDashboardId] evaluating to undefined if prebuiltDashboardId exists but is not a recognized key. Subsequently, attempting to access .filters on undefined will cause a runtime crash. This can occur due to incomplete deployments, API mismatches, or server/client version discrepancies.

💡 Suggested Fix

Before accessing PREBUILT_DASHBOARDS[prebuiltDashboardId], add a check to ensure prebuiltDashboardId in PREBUILT_DASHBOARDS to prevent accessing properties on undefined.

🤖 Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: static/app/views/dashboards/filtersBar.tsx#L73-L75

Potential issue: The code at `static/app/views/dashboards/filtersBar.tsx:73-75` accesses
`PREBUILT_DASHBOARDS[prebuiltDashboardId]` without validating if `prebuiltDashboardId`
is a valid key within `PREBUILT_DASHBOARDS`. This can lead to
`PREBUILT_DASHBOARDS[prebuiltDashboardId]` evaluating to `undefined` if
`prebuiltDashboardId` exists but is not a recognized key. Subsequently, attempting to
access `.filters` on `undefined` will cause a runtime crash. This can occur due to
incomplete deployments, API mismatches, or server/client version discrepancies.

_{Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 6235892}

[DominikB2014]

typing wouldn't allow this

[Ahmed-Labs]

Lgtm!