reducer: refactor complexity to On (#103672)

Refactor reducer spread or concat operations in a couple places where
this might be sensitive

Author: JonasBa

static/app/components/core/compactSelect/utils.tsx

@@ -66,7 +66,7 @@ export function getSelectedOptions<Value extends SelectKey>(
     // If this is an option
     if (selection === 'all' || selection.has(cur.key)) {
       const {key: _key, ...opt} = cur;
-      return acc.concat(opt);
+      acc.push(opt);
     }
     return acc;
   }, []);
@@ -81,19 +81,24 @@ export function getDisabledOptions<Value extends SelectKey>(
   items: Array<SelectOptionOrSectionWithKey<Value>>,
   isOptionDisabled?: (opt: SelectOptionWithKey<Value>) => boolean
 ): SelectKey[] {
-  return items.reduce((acc: SelectKey[], cur) => {
+  return items.reduce<SelectKey[]>((acc, cur) => {
     // If this is a section
     if ('options' in cur) {
       if (cur.disabled) {
         // If the entire section is disabled, then mark all of its children as disabled
-        return acc.concat(cur.options.map(opt => opt.key));
+        for (const opt of cur.options) {
+          acc.push(opt.key);
+        }
+        return acc;
       }
+
       return acc.concat(getDisabledOptions(cur.options, isOptionDisabled));
     }
 
     // If this is an option
     if (isOptionDisabled?.(cur) ?? cur.disabled) {
-      return acc.concat(cur.key);
+      acc.push(cur.key);
+      return acc;
     }
     return acc;
   }, []);

static/app/components/dropdownMenu/index.tsx

@@ -35,11 +35,12 @@ function removeHiddenItemsAndSetHref(source: MenuItemProps[]): MenuItemProps[] {
  * Recursively finds and returns disabled items
  */
 function getDisabledKeys(source: MenuItemProps[]): Array<MenuItemProps['key']> {
-  return source.reduce<string[]>((acc, cur) => {
+  return source.reduce<Array<MenuItemProps['key']>>((acc, cur) => {
     if (cur.disabled) {
       // If an item is disabled, then its children will be inaccessible, so we
       // can skip them and just return the parent item
-      return acc.concat([cur.key]);
+      acc.push(cur.key);
+      return acc;
     }
 
     if (cur.children) {

static/app/components/events/eventTags/util.tsx

@@ -147,12 +147,12 @@ export const TagFilterData = {
  * Combines all of the above into a single set to determine if a tag is custom
  */
 export function getSentryDefaultTags() {
-  return Object.values(TagFilterData).reduce(
-    // TODO: result.union(s) when Set.prototype.union is Baseline
-    // https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Set/union
-    (result, s) => new Set([...result, ...s]),
-    new Set([])
-  );
+  return Object.values(TagFilterData).reduce<Set<string>>((acc, set) => {
+    for (const tag of set) {
+      acc.add(tag);
+    }
+    return acc;
+  }, new Set());
 }
 
 const ISSUE_DETAILS_COLUMN_BREAKPOINTS = [

static/app/components/searchQueryBuilder/utils.tsx

@@ -166,7 +166,8 @@ export function collapseTextTokens(tokens: ParseResult | null) {
       return acc;
     }
 
-    return [...acc, token];
+    acc.push(token);
+    return acc;
   }, []);
 }
 

static/app/views/explore/logs/tables/logsTableRow.tsx

@@ -45,7 +45,10 @@ import {
   useLogsAutoRefreshEnabled,
   useSetLogsAutoRefresh,
 } from 'sentry/views/explore/contexts/logs/logsAutoRefreshContext';
-import type {TraceItemDetailsResponse} from 'sentry/views/explore/hooks/useTraceItemDetails';
+import type {
+  TraceItemDetailsResponse,
+  TraceItemResponseAttribute,
+} from 'sentry/views/explore/hooks/useTraceItemDetails';
 import {useFetchTraceItemDetailsOnHover} from 'sentry/views/explore/hooks/useTraceItemDetails';
 import {
   DEFAULT_TRACE_ITEM_HOVER_TIMEOUT,
@@ -502,11 +505,23 @@ function LogRowDetails({
   const theme = useTheme();
   const logColors = getLogColors(level, theme);
   const attributes =
-    data?.attributes?.reduce((it, {name, value}) => ({...it, [name]: value}), {
-      [OurLogKnownFieldKey.TIMESTAMP]: dataRow[OurLogKnownFieldKey.TIMESTAMP],
-    }) ?? {};
+    data?.attributes?.reduce<Record<string, TraceItemResponseAttribute['value']>>(
+      (it, attr) => {
+        it[attr.name] = attr.value;
+        return it;
+      },
+      {
+        [OurLogKnownFieldKey.TIMESTAMP]: dataRow[OurLogKnownFieldKey.TIMESTAMP],
+      }
+    ) ?? {};
   const attributeTypes =
-    data?.attributes?.reduce((it, {name, type}) => ({...it, [name]: type}), {}) ?? {};
+    data?.attributes?.reduce<Record<string, TraceItemResponseAttribute['type']>>(
+      (it, attr) => {
+        it[attr.name] = attr.type;
+        return it;
+      },
+      {}
+    ) ?? {};
 
   if (missingLogId || isError) {
     return (