Skip to content

Commit 4de2568

Browse files
authored
feat(cells): make email capture demo mode control-silo only (#104488)
note: it is safe to ship frontend + backend together in this case as backend currently works in both silos
1 parent b2d06fc commit 4de2568

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

src/sentry/api/endpoints/email_capture.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
from sentry.api.api_owners import ApiOwner
77
from sentry.api.api_publish_status import ApiPublishStatus
8-
from sentry.api.base import Endpoint, all_silo_endpoint
8+
from sentry.api.base import Endpoint, control_silo_endpoint
99
from sentry.api.serializers.rest_framework.base import CamelSnakeSerializer
1010
from sentry.demo_mode.utils import is_demo_mode_enabled
1111
from sentry.utils.marketo_client import MarketoClient
@@ -17,8 +17,7 @@ class EmailCaptureSerializer(CamelSnakeSerializer):
1717
email = serializers.EmailField(required=True)
1818

1919

20-
# TODO(cells): This endpoint is moving to control
21-
@all_silo_endpoint
20+
@control_silo_endpoint
2221
class EmailCaptureEndpoint(Endpoint):
2322
publish_status = {
2423
"POST": ApiPublishStatus.PRIVATE,

static/app/data/controlsiloUrlPatterns.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,7 @@ const patterns: RegExp[] = [
153153
new RegExp('^api/0/wizard/[^/]+/$'),
154154
new RegExp('^api/0/internal/beacon/$'),
155155
new RegExp('^api/0/internal/integration-proxy/$'),
156+
new RegExp('^api/0/internal/demo/email-capture/$'),
156157
new RegExp('^api/0/internal/notifications/registered-templates/$'),
157158
new RegExp('^api/0/uptime-ips/$'),
158159
new RegExp('^api/0/tempest-ips/$'),

tests/sentry/api/endpoints/test_email_capture.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,11 @@
44

55
from sentry.testutils.cases import APITestCase
66
from sentry.testutils.helpers.options import override_options
7+
from sentry.testutils.silo import control_silo_test
78
from sentry.utils.marketo_client import MarketoClient
89

910

11+
@control_silo_test
1012
class EmailCaptureTest(APITestCase):
1113
def setUp(self) -> None:
1214
super().setUp()

0 commit comments

Comments
 (0)