Skip to content

Commit 7e5b395

Browse files
Merge branch 'webb/keep-single-message' into webb/set-original-messages-attribute
2 parents 6dc02f9 + 0628d92 commit 7e5b395

1 file changed

Lines changed: 8 additions & 9 deletions

File tree

tests/test_ai_monitoring.py

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -320,7 +320,7 @@ def test_single_message_truncation(self):
320320

321321

322322
class TestTruncateAndAnnotateMessages:
323-
def test_no_truncation_returns_list(self, sample_messages):
323+
def test_only_keeps_last_message(self, sample_messages):
324324
class MockSpan:
325325
def __init__(self):
326326
self.span_id = "test_span_id"
@@ -339,9 +339,8 @@ def __init__(self):
339339

340340
assert isinstance(result, list)
341341
assert not isinstance(result, AnnotatedValue)
342-
assert len(result) == len(sample_messages)
343-
assert result == sample_messages
344-
assert span.span_id not in scope._gen_ai_original_message_count
342+
assert len(result) == 1
343+
assert result[0] == sample_messages[-1]
345344

346345
def test_truncation_sets_metadata_on_scope(self, large_messages):
347346
class MockSpan:
@@ -361,7 +360,7 @@ def __init__(self):
361360
scope = MockScope()
362361
original_count = len(large_messages)
363362
result = truncate_and_annotate_messages(
364-
large_messages, span, scope, max_bytes=small_limit
363+
large_messages, span, scope, max_single_message_chars=small_limit
365364
)
366365

367366
assert isinstance(result, list)
@@ -388,7 +387,7 @@ def __init__(self):
388387
scope = MockScope()
389388

390389
result = truncate_and_annotate_messages(
391-
large_messages, span, scope, max_bytes=small_limit
390+
large_messages, span, scope, max_single_message_chars=small_limit
392391
)
393392

394393
assert scope._gen_ai_original_message_count[span.span_id] == original_count
@@ -432,7 +431,7 @@ def __init__(self):
432431
span = MockSpan()
433432
scope = MockScope()
434433
result = truncate_and_annotate_messages(
435-
large_messages, span, scope, max_bytes=small_limit
434+
large_messages, span, scope, max_single_message_chars=small_limit
436435
)
437436

438437
assert isinstance(result, list)
@@ -507,7 +506,7 @@ def __init__(self):
507506

508507
# Simulate what integrations do
509508
truncated_messages = truncate_and_annotate_messages(
510-
large_messages, span, scope, max_bytes=small_limit
509+
large_messages, span, scope, max_single_message_chars=small_limit
511510
)
512511
span.set_data(SPANDATA.GEN_AI_REQUEST_MESSAGES, truncated_messages)
513512

@@ -563,7 +562,7 @@ def __init__(self):
563562
original_message_count = len(large_messages)
564563

565564
truncated_messages = truncate_and_annotate_messages(
566-
large_messages, span, scope, max_bytes=small_limit
565+
large_messages, span, scope, max_single_message_chars=small_limit
567566
)
568567

569568
assert len(truncated_messages) < original_message_count

0 commit comments

Comments
 (0)