Commit 38f97c2
refactor: Address reviewer feedback
- Remove all hasattr(transport, 'loop') checks in client.py — redundant
since AsyncHttpTransport.__init__ always sets self.loop
- Remove irrelevant lore entries from AGENTS.md (Consola, Zod, remark-lint)
- Remove duplicate and implementation-detail tests per reviewer:
- asyncio tests: keep only e2e tests (test_internal_tasks_not_wrapped,
test_loop_close_patching, test_loop_close_flushes_async_transport)
- client tests: remove _close_components/_flush_components detail tests
- transport tests: remove all sync-wrapper and mock-based coverage tests
that were not reviewable
- Remove section separator comments from test files
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>1 parent 94b6c73 commit 38f97c2
5 files changed
Lines changed: 6 additions & 2255 deletions
File tree
- sentry_sdk
- tests
- integrations/asyncio
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
72 | | - | |
73 | | - | |
74 | | - | |
75 | | - | |
76 | | - | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | 72 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1037 | 1037 | | |
1038 | 1038 | | |
1039 | 1039 | | |
1040 | | - | |
1041 | | - | |
1042 | | - | |
| 1040 | + | |
1043 | 1041 | | |
1044 | 1042 | | |
1045 | 1043 | | |
| |||
1062 | 1060 | | |
1063 | 1061 | | |
1064 | 1062 | | |
1065 | | - | |
1066 | | - | |
1067 | | - | |
1068 | | - | |
| 1063 | + | |
1069 | 1064 | | |
1070 | 1065 | | |
1071 | 1066 | | |
| |||
1090 | 1085 | | |
1091 | 1086 | | |
1092 | 1087 | | |
1093 | | - | |
1094 | | - | |
1095 | | - | |
| 1088 | + | |
1096 | 1089 | | |
1097 | 1090 | | |
1098 | 1091 | | |
| |||
1116 | 1109 | | |
1117 | 1110 | | |
1118 | 1111 | | |
1119 | | - | |
1120 | | - | |
1121 | | - | |
1122 | | - | |
| 1112 | + | |
1123 | 1113 | | |
1124 | 1114 | | |
1125 | 1115 | | |
| |||
0 commit comments