Skip to content

Commit da5b10a

Browse files
mydeaclaude
andauthored
ref: Remove unused SENTRY_BUILD_PRESERVE_MODULES env check from rollup configs (#21487)
The `SENTRY_BUILD_PRESERVE_MODULES` environment variable is never set anywhere in the codebase, so the `preserveModules` ternary in our `rollup.npm.config.mjs` files always resolved to its default (`undefined`) branch. I _think_ we had this because we experimented with this or used this for some analysis steps back in the day, but I do not think anybodoy/anything ever sets this nowadays. This removes the dead env check across all 9 affected packages, collapsing each ternary to the static value it always produced: - `preserveModules: true` — `core`, `server-utils`, `browser`, `browser-utils` - `preserveModules: false` — `opentelemetry`, `feedback`, `profiling-node`, `replay-canvas`, `replay-internal` No behavior change: build output is identical. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent d3474ec commit da5b10a

9 files changed

Lines changed: 9 additions & 36 deletions

File tree

packages/browser-utils/rollup.npm.config.mjs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,7 @@ export default makeNPMConfigVariants(
77
// set exports to 'named' or 'auto' so that rollup doesn't warn
88
exports: 'named',
99
// set preserveModules to true because we don't want to bundle everything into one file.
10-
preserveModules:
11-
process.env.SENTRY_BUILD_PRESERVE_MODULES === undefined
12-
? true
13-
: Boolean(process.env.SENTRY_BUILD_PRESERVE_MODULES),
10+
preserveModules: true,
1411
},
1512
},
1613
}),

packages/browser/rollup.npm.config.mjs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,7 @@ export default makeNPMConfigVariants(
99
// set exports to 'named' or 'auto' so that rollup doesn't warn
1010
exports: 'named',
1111
// set preserveModules to true because we don't want to bundle everything into one file.
12-
preserveModules:
13-
process.env.SENTRY_BUILD_PRESERVE_MODULES === undefined
14-
? true
15-
: Boolean(process.env.SENTRY_BUILD_PRESERVE_MODULES),
12+
preserveModules: true,
1613
},
1714
},
1815
}),

packages/core/rollup.npm.config.mjs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,7 @@ const settings = {
2020
// set exports to 'named' or 'auto' so that rollup doesn't warn
2121
exports: 'named',
2222
// set preserveModules to true because we don't want to bundle everything into one file.
23-
preserveModules:
24-
process.env.SENTRY_BUILD_PRESERVE_MODULES === undefined
25-
? true
26-
: Boolean(process.env.SENTRY_BUILD_PRESERVE_MODULES),
23+
preserveModules: true,
2724
},
2825
plugins: [
2926
replace({

packages/feedback/rollup.npm.config.mjs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,7 @@ export default makeNPMConfigVariants(
99
exports: 'named',
1010
// set preserveModules to false because for feedback we actually want
1111
// to bundle everything into one file.
12-
preserveModules:
13-
process.env.SENTRY_BUILD_PRESERVE_MODULES === undefined
14-
? false
15-
: Boolean(process.env.SENTRY_BUILD_PRESERVE_MODULES),
12+
preserveModules: false,
1613
},
1714
},
1815
esbuild: {

packages/opentelemetry/rollup.npm.config.mjs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,7 @@ export default makeNPMConfigVariants(
1010
// set exports to 'named' or 'auto' so that rollup doesn't warn
1111
exports: 'named',
1212
// set preserveModules to false because we want to bundle everything into one file.
13-
preserveModules:
14-
process.env.SENTRY_BUILD_PRESERVE_MODULES === undefined
15-
? false
16-
: Boolean(process.env.SENTRY_BUILD_PRESERVE_MODULES),
13+
preserveModules: false,
1714
},
1815
},
1916
}),

packages/profiling-node/rollup.npm.config.mjs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,7 @@ export default makeNPMConfigVariants(
99
exports: 'named',
1010
// set preserveModules to false because for profiling we actually want
1111
// to bundle everything into one file.
12-
preserveModules:
13-
process.env.SENTRY_BUILD_PRESERVE_MODULES === undefined
14-
? false
15-
: Boolean(process.env.SENTRY_BUILD_PRESERVE_MODULES),
12+
preserveModules: false,
1613
},
1714
},
1815
}),

packages/replay-canvas/rollup.npm.config.mjs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,7 @@ export default makeNPMConfigVariants(
99
exports: 'named',
1010
// set preserveModules to false because for Replay we actually want
1111
// to bundle everything into one file.
12-
preserveModules:
13-
process.env.SENTRY_BUILD_PRESERVE_MODULES === undefined
14-
? false
15-
: Boolean(process.env.SENTRY_BUILD_PRESERVE_MODULES),
12+
preserveModules: false,
1613
},
1714
},
1815
}),

packages/replay-internal/rollup.npm.config.mjs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,7 @@ export default makeNPMConfigVariants(
1111
exports: 'named',
1212
// set preserveModules to false because for Replay we actually want
1313
// to bundle everything into one file.
14-
preserveModules:
15-
process.env.SENTRY_BUILD_PRESERVE_MODULES === undefined
16-
? false
17-
: Boolean(process.env.SENTRY_BUILD_PRESERVE_MODULES),
14+
preserveModules: false,
1815
},
1916
},
2017
}),

packages/server-utils/rollup.npm.config.mjs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,7 @@ export default makeNPMConfigVariants(
77
// set exports to 'named' or 'auto' so that rollup doesn't warn
88
exports: 'named',
99
// set preserveModules to true because we don't want to bundle everything into one file.
10-
preserveModules:
11-
process.env.SENTRY_BUILD_PRESERVE_MODULES === undefined
12-
? true
13-
: Boolean(process.env.SENTRY_BUILD_PRESERVE_MODULES),
10+
preserveModules: true,
1411
},
1512
},
1613
}),

0 commit comments

Comments
 (0)