Coerce message passed to captureMessage to a string as well

Author: mattrobenolt

src/raven.js

@@ -218,8 +218,8 @@ var Raven = {
      * @return {Raven}
      */
     captureException: function(ex, options) {
-        // If a string is passed through, recall as a message
-        if (isString(ex)) return Raven.captureMessage(ex, options);
+        // If not an Error is passed through, recall as a message instead
+        if (!(ex instanceof Error)) return Raven.captureMessage(ex, options);
 
         // Store the raw exception object for potential debugging and introspection
         lastCapturedException = ex;
@@ -251,7 +251,7 @@ var Raven = {
         // Fire away!
         send(
             objectMerge({
-                message: msg
+                message: msg + ''  // Make sure it's actually a string
             }, options)
         );
 

test/raven.test.js

@@ -1301,6 +1301,14 @@ describe('Raven (public API)', function() {
             }]);
         });
 
+        it('should coerce message to a string', function() {
+            this.sinon.stub(window, 'send');
+            Raven.captureMessage({});
+            assert.deepEqual(window.send.lastCall.args, [{
+                message: '[object Object]'
+            }]);
+        });
+
         it('should work as advertised #integration', function() {
             imageCache = [];
             setupRaven();
@@ -1351,12 +1359,15 @@ describe('Raven (public API)', function() {
             }, error);
         });
 
-        it('should capture as a normal message if a string is passed', function() {
+        it('should capture as a normal message if a non-Error is passed', function() {
             this.sinon.stub(Raven, 'captureMessage');
             this.sinon.stub(TraceKit, 'report');
             Raven.captureException('derp');
             assert.equal(Raven.captureMessage.lastCall.args[0], 'derp');
             assert.isFalse(TraceKit.report.called);
+            Raven.captureException(true);
+            assert.equal(Raven.captureMessage.lastCall.args[0], true);
+            assert.isFalse(TraceKit.report.called);
         });
     });
 });