check for both stacktraces before calling 'isSameException'

Author: zivl

src/utils.js

@@ -322,6 +322,13 @@ function isOnlyOneTruthy(a, b) {
   return !!(!!a ^ !!b);
 }
 
+/**
+ * Returns true if both parameters are undefined
+ */
+function isBothUndefined(a, b) {
+  return isUndefined(a) && isUndefined(b);
+}
+
 /**
  * Returns true if the two input exception interfaces have the same content
  */
@@ -333,6 +340,9 @@ function isSameException(ex1, ex2) {
 
   if (ex1.type !== ex2.type || ex1.value !== ex2.value) return false;
 
+  // in case both stacktraces are undefined, we can't decide so default to false
+  if (isBothUndefined(ex1.stacktrace, ex2.stacktrace)) return false;
+
   return isSameStacktrace(ex1.stacktrace, ex2.stacktrace);
 }
 

test/raven.test.js

@@ -3527,6 +3527,14 @@ describe('Raven (private methods)', function() {
         data.exception.values[0].stacktrace.frames = [];
         assert.isFalse(Raven._isRepeatData(data));
       });
+
+      it('should not blown if both stacktraces are undefined', function() {
+        Raven._lastData.exception.values[0].stacktrace = undefined;
+        var data1 = JSON.parse(JSON.stringify(Raven._lastData)); // copy
+        var data2 = JSON.parse(JSON.stringify(Raven._lastData)); // copy
+        assert.isFalse(Raven._isRepeatData(data1));
+        assert.isFalse(Raven._isRepeatData(data2));
+      });
     });
   });
 });