fix: add explicit type assertions for dynamic imports to resolve CI linting errors

- Add type assertions for all await loader() calls in plugin-registry.ts
- Type workflowModule as Record<string, unknown> in dynamic-tools.ts
- Type resource as ResourceMeta in resources.ts
- Fix potential undefined version in template-manager.ts with String()
- Use nullish coalescing operator (??) instead of logical OR (||)

These changes ensure TypeScript's type inference works consistently
between local development and CI environments, preventing unsafe
assignment and member access errors detected by ESLint's TypeScript rules.

Author: cameroncooke

src/core/plugin-registry.ts

@@ -27,14 +27,17 @@ export async function loadWorkflowGroups(): Promise<Map<string, WorkflowGroup>>
   for (const [workflowName, loader] of Object.entries(WORKFLOW_LOADERS)) {
     try {
       // Dynamic import with code-splitting
-      const workflowModule = await loader();
+      const workflowModule = (await loader()) as {
+        workflow?: WorkflowMeta;
+        [key: string]: unknown;
+      };
 
       if (!workflowModule.workflow) {
         throw new Error(`Workflow metadata missing in ${workflowName}/index.js`);
       }
 
       // Validate required fields
-      const workflowMeta = workflowModule.workflow;
+      const workflowMeta = workflowModule.workflow as WorkflowMeta;
       if (!workflowMeta.name || typeof workflowMeta.name !== 'string') {
         throw new Error(
           `Invalid workflow.name in ${workflowName}/index.js: must be a non-empty string`,
@@ -95,8 +98,8 @@ export async function getWorkflowMetadata(directoryName: string): Promise<Workfl
     // Fall back to loading the actual module
     const loader = WORKFLOW_LOADERS[directoryName as WorkflowName];
     if (loader) {
-      const workflowModule = await loader();
-      return workflowModule.workflow || null;
+      const workflowModule = (await loader()) as { workflow?: WorkflowMeta };
+      return workflowModule.workflow ?? null;
     }
 
     return null;

src/core/resources.ts

@@ -41,7 +41,7 @@ export async function loadResources(): Promise<Map<string, ResourceMeta>> {
 
   for (const [resourceName, loader] of Object.entries(RESOURCE_LOADERS)) {
     try {
-      const resource = await loader();
+      const resource = (await loader()) as ResourceMeta;
 
       if (!resource.uri || !resource.handler || typeof resource.handler !== 'function') {
         throw new Error(`Invalid resource structure for ${resourceName}`);

src/utils/template-manager.ts

@@ -67,8 +67,9 @@ export class TemplateManager {
       platform === 'iOS'
         ? 'XCODEBUILD_MCP_IOS_TEMPLATE_VERSION'
         : 'XCODEBUILD_MCP_MACOS_TEMPLATE_VERSION';
-    const version =
-      process.env[envVarName] ?? process.env.XCODEBUILD_MCP_TEMPLATE_VERSION ?? defaultVersion;
+    const version = String(
+      process.env[envVarName] ?? process.env.XCODEBUILD_MCP_TEMPLATE_VERSION ?? defaultVersion,
+    );
 
     // Create temp directory for download
     const tempDir = join(tmpdir(), `xcodebuild-mcp-template-${randomUUID()}`);