Replace all AJAX with REST API and refactor controllers

- Remove DismissalHandler (AJAX dismissal) and merge dismiss endpoint
  into NoticeRESTController as POST /notices/dismiss
- Extract migration REST endpoints from MigrationHooks into dedicated
  MigrationRESTController with GET /migration/status and POST
  /migration/upgrade
- Rename NotificationHelper::ajax_action() to rest_action() with
  REST-oriented signature (endpoint, method, nonce)
- Add WP REST class stubs to test bootstrap for Brain\Monkey compat
- Update tests and developer guide to reflect all changes

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: mrabbani

docs/developer-guide.md

@@ -80,8 +80,8 @@ use WeDevs\WPKit\DataLayer\DataLayerFactory;
 use WeDevs\WPKit\Migration\MigrationRegistry;
 use WeDevs\WPKit\Migration\MigrationManager;
 use WeDevs\WPKit\Migration\MigrationHooks;
+use WeDevs\WPKit\Migration\MigrationRESTController;
 use WeDevs\WPKit\AdminNotification\NoticeManager;
-use WeDevs\WPKit\AdminNotification\DismissalHandler;
 use WeDevs\WPKit\AdminNotification\NoticeRESTController;
 
 // 1. DataLayer
@@ -100,9 +100,10 @@ $manager = new MigrationManager( $registry, 'myplugin' );
 
 // 3. Admin Notifications
 $notices = new NoticeManager( 'myplugin' );
-( new DismissalHandler( 'myplugin' ) )->register();
 
-add_action( 'rest_api_init', function () use ( $notices ) {
+// 4. REST API (migration + notifications)
+add_action( 'rest_api_init', function () use ( $manager, $notices ) {
+    ( new MigrationRESTController( $manager, 'myplugin/v1' ) )->register_routes();
     ( new NoticeRESTController( $notices, 'myplugin/v1' ) )->register_routes();
 } );
 ```
@@ -983,9 +984,13 @@ $registry->get_pending_migrations();   // versions > installed, sorted by versio
 $manager = new MigrationManager( $registry, 'myplugin' );
 $manager->do_upgrade(); // Runs all pending, fires {prefix}_upgrade_finished
 
-// MigrationHooks: adds WordPress AJAX handler and filter hooks
+// MigrationHooks: adds WordPress filter hooks
 $hooks = new MigrationHooks( $manager, 'myplugin' );
 $hooks->register();
+
+// MigrationRESTController: REST API for status and upgrade
+$rest = new MigrationRESTController( $manager, 'myplugin/v1' );
+add_action( 'rest_api_init', [ $rest, 'register_routes' ] );
 ```
 
 #### WordPress Hooks Registered by MigrationHooks
@@ -994,11 +999,15 @@ $hooks->register();
 |------|------|-------------|
 | `{prefix}_upgrade_is_upgrade_required` | filter | Returns whether upgrade is needed |
 | `{prefix}_upgrade_upgrades` | filter | Returns pending upgrade list |
-| `wp_ajax_{prefix}_do_upgrade` | action | AJAX endpoint for admin-triggered upgrades |
 | `{prefix}_upgrade_finished` | action | Fires after all migrations complete |
 | `{prefix}_upgrade_is_not_required` | action | Fires when no upgrade is needed |
 
-The AJAX handler verifies the nonce `{prefix}_admin` and requires the `update_plugins` capability.
+#### Migration REST Endpoints
+
+| Endpoint | Method | Description |
+|----------|--------|-------------|
+| `{prefix}/v1/migration/status` | GET | Returns migration status, log, and summary |
+| `{prefix}/v1/migration/upgrade` | POST | Triggers admin upgrade (requires `update_plugins` capability) |
 
 #### Migration Status
 
@@ -1045,7 +1054,7 @@ if ( $entry && $entry['status'] === 'failed' ) {
 
 #### REST API for Migration Status
 
-`MigrationHooks` registers a REST endpoint for polling migration status from the admin UI:
+`MigrationRESTController` provides REST endpoints for polling migration status and triggering upgrades from the admin UI:
 
 ```
 GET /wp-json/{prefix}/v1/migration/status
@@ -1222,7 +1231,7 @@ if ( $progress['is_processing'] ) {
 
 ## Admin Notifications
 
-A system for collecting, filtering, and serving admin notices via REST API with AJAX dismissal support.
+A system for collecting, filtering, and serving admin notices via REST API.
 
 ### Notice Providers
 
@@ -1317,7 +1326,7 @@ $notice = NotificationHelper::warning( 'Update Available', 'Version 2.0 is out.'
     'is_dismissible' => true,
     'actions'        => [
         NotificationHelper::link_action( 'Update Now', admin_url( 'update-core.php' ) ),
-        NotificationHelper::ajax_action( 'Remind Later', 'myplugin_snooze', 'myplugin_admin' ),
+        NotificationHelper::rest_action( 'Remind Later', '/wp-json/myplugin/v1/snooze' ),
     ],
 ] );
 ```
@@ -1330,26 +1339,9 @@ $notice = NotificationHelper::warning( 'Update Available', 'Version 2.0 is out.'
 | info | 10 | local |
 | success | 10 | local |
 
-### DismissalHandler
-
-Handles AJAX notice dismissal and persists dismissed notice keys:
-
-```php
-$handler = new DismissalHandler( 'myplugin' );
-$handler->register(); // Registers wp_ajax_{prefix}_dismiss_notice
-```
-
-Dismissed notices are stored in the `{prefix}_dismissed_notices` option as an array of keys.
-
-**AJAX endpoint details:**
-- Action: `wp_ajax_myplugin_dismiss_notice`
-- Nonce action: `myplugin_admin`
-- Required capability: `manage_options`
-- POST parameter: `key` (the notice key to dismiss)
-
 ### REST Controller
 
-Exposes notices via the WordPress REST API:
+Exposes notices via the WordPress REST API and handles notice dismissal:
 
 ```php
 $controller = new NoticeRESTController( $manager, 'myplugin/v1' );
@@ -1359,13 +1351,16 @@ add_action( 'rest_api_init', function () use ( $controller ) {
 } );
 ```
 
-**Endpoint:** `GET /wp-json/myplugin/v1/notices/admin`
+**Endpoints:**
 
-| Parameter | Type | Required | Description |
-|-----------|------|----------|-------------|
-| `scope` | string | No | `'local'` or `'global'`. Omit for all. |
+| Endpoint | Method | Description |
+|----------|--------|-------------|
+| `/wp-json/myplugin/v1/notices/admin` | GET | Get all notices (optional `scope` param: `local` or `global`) |
+| `/wp-json/myplugin/v1/notices/dismiss` | POST | Dismiss a notice (required `key` param) |
+
+Dismissed notices are stored in the `{prefix}_dismissed_notices` option as an array of keys.
 
-**Permission:** Requires `manage_options` capability.
+**Permission:** All endpoints require `manage_options` capability.
 
 ---
 
@@ -1697,7 +1692,6 @@ The `{prefix}` is the plugin-level prefix set via `set_filter_prefix()` (e.g., `
 |------|------|------------|-------------|
 | `{prefix}_upgrade_is_upgrade_required` | filter | `$required` | Check if upgrade is needed |
 | `{prefix}_upgrade_upgrades` | filter | `$upgrades` | Get pending upgrades list |
-| `wp_ajax_{prefix}_do_upgrade` | action | — | AJAX endpoint for admin-triggered upgrades |
 | `{prefix}_upgrade_finished` | action | — | All migrations completed |
 | `{prefix}_upgrade_is_not_required` | action | — | No upgrade needed |
 
@@ -1706,13 +1700,20 @@ The `{prefix}` is the plugin-level prefix set via `set_filter_prefix()` (e.g., `
 | Route | Method | Permission | Description |
 |-------|--------|------------|-------------|
 | `{prefix}/v1/migration/status` | GET | `update_plugins` | Returns migration log, summary, and status |
+| `{prefix}/v1/migration/upgrade` | POST | `update_plugins` | Triggers admin upgrade |
 
 ### Notification Hooks
 
 | Hook | Type | Parameters | Description |
 |------|------|------------|-------------|
 | `{prefix}_admin_notices` | filter | `$notices` | Collect/modify admin notices |
-| `wp_ajax_{prefix}_dismiss_notice` | action | — | AJAX dismissal endpoint |
+
+### Notification REST Endpoints
+
+| Route | Method | Permission | Description |
+|-------|--------|------------|-------------|
+| `{namespace}/notices/admin` | GET | `manage_options` | Get admin notices (optional `scope` param) |
+| `{namespace}/notices/dismiss` | POST | `manage_options` | Dismiss a notice (required `key` param) |
 
 ### WordPress Options Used
 
@@ -1723,4 +1724,4 @@ The `{prefix}` is the plugin-level prefix set via `set_filter_prefix()` (e.g., `
 | `{prefix}_migration_log` | MigrationManager | Per-migration execution log (version, status, timestamps, errors) |
 | `{prefix}_bg_{action}` | BackgroundProcess | Queue storage (array of items) |
 | `{prefix}_bg_{action}_total` | BackgroundProcess | Total items pushed (for progress percentage) |
-| `{prefix}_dismissed_notices` | DismissalHandler | Array of dismissed notice keys |
+| `{prefix}_dismissed_notices` | NoticeRESTController | Array of dismissed notice keys |

src/AdminNotification/DismissalHandler.php

@@ -64,6 +64,25 @@ public function register_routes(): void {
 				],
 			]
 		);
+
+		register_rest_route(
+			$this->namespace,
+			'/' . $this->base . '/dismiss',
+			[
+				[
+					'methods'             => WP_REST_Server::CREATABLE,
+					'callback'            => [ $this, 'dismiss_notice' ],
+					'permission_callback' => [ $this, 'check_permission' ],
+					'args'                => [
+						'key' => [
+							'required'          => true,
+							'type'              => 'string',
+							'sanitize_callback' => 'sanitize_text_field',
+						],
+					],
+				],
+			]
+		);
 	}
 
 	/**
@@ -80,6 +99,27 @@ public function get_admin_notices( WP_REST_Request $request ): WP_REST_Response
 		return rest_ensure_response( $notices );
 	}
 
+	/**
+	 * Dismiss a notice by key.
+	 *
+	 * @param WP_REST_Request $request REST request.
+	 *
+	 * @return WP_REST_Response
+	 */
+	public function dismiss_notice( WP_REST_Request $request ): WP_REST_Response {
+		$key    = $request->get_param( 'key' );
+		$prefix = $this->manager->get_prefix();
+
+		$dismissed = get_option( $prefix . '_dismissed_notices', [] );
+
+		if ( ! in_array( $key, $dismissed, true ) ) {
+			$dismissed[] = $key;
+			update_option( $prefix . '_dismissed_notices', $dismissed );
+		}
+
+		return new WP_REST_Response( [ 'success' => true ], 200 );
+	}
+
 	/**
 	 * Check if the current user has permission.
 	 *

src/AdminNotification/NoticeRESTController.php

@@ -96,23 +96,24 @@ public static function success( string $title, string $description, array $extra
 	}
 
 	/**
-	 * Build an AJAX action button config.
+	 * Build a REST API action button config.
 	 *
-	 * @param string $text         Button text.
-	 * @param string $ajax_action  The AJAX action name.
-	 * @param string $nonce_action The nonce action.
-	 * @param array  $extra        Additional action properties.
+	 * @param string $text     Button text.
+	 * @param string $endpoint REST API endpoint URL.
+	 * @param string $method   HTTP method (default: POST).
+	 * @param array  $extra    Additional action properties.
 	 *
 	 * @return array
 	 */
-	public static function ajax_action( string $text, string $ajax_action, string $nonce_action, array $extra = [] ): array {
+	public static function rest_action( string $text, string $endpoint, string $method = 'POST', array $extra = [] ): array {
 		return array_merge(
 			[
 				'type'      => 'primary',
 				'text'      => $text,
-				'ajax_data' => [
-					'action'   => $ajax_action,
-					'_wpnonce' => wp_create_nonce( $nonce_action ),
+				'rest_data' => [
+					'endpoint' => $endpoint,
+					'method'   => $method,
+					'nonce'    => wp_create_nonce( 'wp_rest' ),
 				],
 			],
 			$extra