refactor: improve pylint score a little

Author: apotterri

_appmap/django.py

@@ -12,7 +12,7 @@
 from . import remote_recording
 
 
-class RemoteRecording:  # pylint: disable=missing-class-docstring
+class RemoteRecording:  # pylint: disable=missing-class-docstring,too-few-public-methods
     def __init__(self, get_response):
         super().__init__()
         self.get_response = get_response

_appmap/event.py

@@ -329,7 +329,7 @@ def to_dict(self, attrs=None):
         return ret
 
 
-class SqlEvent(Event):
+class SqlEvent(Event):  # pylint: disable=too-few-public-methods
     __slots__ = ["sql_query"]
 
     def __init__(self, sql, vendor=None, version=None):
@@ -345,7 +345,7 @@ def __init__(self, sql, vendor=None, version=None):
         )
 
 
-class MessageEvent(Event):
+class MessageEvent(Event):  # pylint: disable=too-few-public-methods
     __slots__ = ["message"]
 
     def __init__(self, message_parameters):

_appmap/generation.py

@@ -19,7 +19,7 @@ def values(self):
         return self._dict.values()
 
 
-class ClassMapEntry:
+class ClassMapEntry:  # pylint: disable=too-few-public-methods
     # pylint: disable=redefined-builtin
     def __init__(self, name, type):
         self.name = name
@@ -32,19 +32,19 @@ def to_dict(self):
         return {k: v for k, v in vars(self).items() if v is not None}
 
 
-class PackageEntry(ClassMapEntry):
+class PackageEntry(ClassMapEntry):  # pylint: disable=too-few-public-methods
     def __init__(self, name):
         super().__init__(name, "package")
         self.children = ClassMapDict()
 
 
-class ClassEntry(ClassMapEntry):
+class ClassEntry(ClassMapEntry):  # pylint: disable=too-few-public-methods
     def __init__(self, name):
         super().__init__(name, "class")
         self.children = ClassMapDict()
 
 
-class FuncEntry(ClassMapEntry):
+class FuncEntry(ClassMapEntry):  # pylint: disable=too-few-public-methods
     def __init__(self, e):
         super().__init__(e.method_id, "function")
         self.location = "%s:%s" % (e.path, e.lineno)

_appmap/importer.py

@@ -62,7 +62,7 @@ def fntype(self):
         return self.scope.classify_fn(self.static_fn)
 
 
-class Filter(ABC):
+class Filter(ABC):  # pylint: disable=too-few-public-methods
     def __init__(self, next_filter):
         self.next_filter = next_filter
 
@@ -75,7 +75,7 @@ def filter(self, filterable):
         """
 
 
-class NullFilter(Filter):
+class NullFilter(Filter):  # pylint: disable=too-few-public-methods
     def __init__(self, next_filter=None):
         super().__init__(next_filter)
 

_appmap/labels.py

@@ -7,7 +7,7 @@
 logger = Env.current.getLogger(__name__)
 
 
-class labels:
+class labels:  # pylint: disable=too-few-public-methods
     def __init__(self, *args):
         self._labels = args
 

_appmap/noappmap.py

@@ -1,5 +1,3 @@
-import sys
-
 _appmap_noappmap = "_appmap_noappmap"
 
 

_appmap/recording.py

@@ -1,5 +1,5 @@
 import atexit
-import datetime
+from datetime import datetime, timezone
 import os
 from tempfile import NamedTemporaryFile
 
@@ -74,7 +74,7 @@ def write_appmap(
     with NamedTemporaryFile(mode="w", dir=basedir, delete=False) as tmp:
         tmp.write(generation.dump(appmap, metadata))
     appmap_file = basedir / filename
-    logger.info("info, writing %s", appmap_file)
+    logger.info("writing %s", appmap_file)
     os.replace(tmp.name, appmap_file)
 
 
@@ -86,14 +86,15 @@ def initialize():
         def save_at_exit():
             nonlocal r
             r.stop()
-            appmap_name = datetime.utcnow().isoformat(timespec='seconds') + "Z"
+            now = datetime.now(timezone.utc)
+            appmap_name = now.isoformat(timespec="seconds").replace("+00:00", "Z")
             recorder_type = "process"
             metadata = {
                 "name": appmap_name,
                 "recorder": {
                     "name": "process",
                     "type": recorder_type,
-                }
+                },
             }
             write_appmap(r, appmap_name, recorder_type, metadata)
 

_appmap/test/data/trial/.gitignore

@@ -1,2 +1 @@
 _trial_temp/
-tmp/

_appmap/test/data/unittest/.gitignore

@@ -125,8 +125,8 @@ def test_pytest_trial(self, testdir):
 RECORDER_TYPE = "test"
 
 
-@pytest.fixture
-def recorder_outdir(tmp_path) -> Path:
+@pytest.fixture(name="recorder_outdir")
+def _recorder_outdir(tmp_path) -> Path:
     ret = tmp_path / RECORDER_TYPE
     ret.mkdir(parents=True)
     return ret