-
Notifications
You must be signed in to change notification settings - Fork 75
docs(sveltekit): add authenticated requests & SSR guide #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…xpectAuth options
|
@erquhart are we ready to merge? 🙂 |
WalkthroughUpdated the SvelteKit framework guide: corrected "SvelteKit" capitalization, simplified client reactive auth state logic, added an "Authenticated requests" section describing two approaches (conditional queries with Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/content/docs/framework-guides/sveltekit.mdx(1 hunks)
🔇 Additional comments (2)
docs/content/docs/framework-guides/sveltekit.mdx (2)
559-607: Verify: "Authenticated requests" section duplication claim.The AI-generated summary indicates this section appears twice in the document. However, only one "Authenticated requests" section is visible in the provided code (lines 560–607 with Option 1 and Option 2). Please verify whether:
- A second identical/similar "Authenticated requests" section exists elsewhere in the file that's not shown in the diff
- The duplication claim in the summary is inaccurate
If duplication exists, consolidate into a single section to avoid redundancy.
560-607: Content and technical accuracy look solid.Both authenticated request patterns are well-explained with clear use cases and working code examples. The conditional skip approach (Option 1) and expectAuth approach (Option 2) are complementary and appropriately documented for different app architectures.
|
The pull request now also includes a documentation section for SSR for auth state, added with 0.4.0 in convex-better-auth-svelte |
This pull request adds to the SvelteKit docs
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Summary by CodeRabbit
expectAuth✏️ Tip: You can customize this high-level summary in your review settings.