add lint testing

Author: scivision

+hdf5nc/MLint.txt

@@ -0,0 +1 @@
+

+hdf5nc/TestALint.m

@@ -0,0 +1,53 @@
+classdef TestALint < matlab.unittest.TestCase
+
+properties
+TestData
+end
+
+methods (TestClassSetup)
+
+function get_files(tc)
+import matlab.unittest.constraints.IsFile
+import matlab.unittest.constraints.IsFolder
+
+cwd = fileparts(mfilename('fullpath'));
+folder = fullfile(cwd, '..');
+cfg_file = fullfile(cwd, "MLint.txt");
+
+tc.assumeThat(folder, IsFolder)
+tc.assumeThat(cfg_file, IsFile)
+
+tc.TestData.folder = folder;
+tc.TestData.cfg_file = cfg_file;
+
+flist = dir(tc.TestData.folder + "/**/*.m");
+N = length(flist);
+tc.assumeGreaterThan(N, 0)
+
+tc.TestData.flist = flist;
+tc.TestData.N = N;
+end
+
+end
+
+methods (Test)
+
+function test_lint(tc)
+
+flist = tc.TestData.flist;
+
+for i = 1:tc.TestData.N
+  file = fullfile(flist(i).folder, flist(i).name);
+
+  res = checkcode(file, "-config=" + tc.TestData.cfg_file, "-fullpath");
+
+  for j = 1:length(res)
+    tc.verifyFail(append(file, ":", int2str(res(j).line), " ", res(j).message))
+  end
+end
+
+end
+
+end
+
+end

+hdf5nc/ncsave.m

@@ -34,7 +34,7 @@ function ncsave(filename, varname, A, opts)
   ncdims = opts.dims;
 
   for i = 2:2:length(opts.dims)
-    sizeA(i/2) = opts.dims{i};
+    sizeA(i/2) = opts.dims{i}; %#ok<AGROW>
   end
 end
 % coerce if needed

+hdf5nc/test_hdf5.m

@@ -43,15 +43,18 @@ function test_auto_chunk_size(tc)
 
 function test_get_variables(tc)
 import hdf5nc.h5variables
+
 vars = h5variables(tc.TestData.basic);
 tc.verifyEqual(sort(vars), ["A0", "A1", "A2", "A3", "A4"])
 end
 
 
 function test_exists(tc)
 import hdf5nc.h5exists
+import matlab.unittest.constraints.IsScalar
+
 e0 = h5exists(tc.TestData.basic, '/A3');
-tc.verifyTrue(isscalar(e0))
+tc.verifyThat(e0, IsScalar)
 tc.verifyTrue(e0)
 
 tc.verifyFalse(h5exists(tc.TestData.basic, '/oops'))
@@ -64,14 +67,15 @@ function test_exists(tc)
 
 function test_size(tc)
 import hdf5nc.h5size
+import matlab.unittest.constraints.IsScalar
 basic = tc.TestData.basic;
 
 s = h5size(basic, '/A0');
-tc.verifyTrue(isscalar(s))
+tc.verifyThat(s, IsScalar)
 tc.verifyEqual(s, 1)
 
 s = h5size(basic, '/A1');
-tc.verifyTrue(isscalar(s))
+tc.verifyThat(s, IsScalar)
 tc.verifyEqual(s, 2)
 
 s = h5size(basic, '/A2');
@@ -89,9 +93,13 @@ function test_size(tc)
 
 
 function test_read(tc)
+import matlab.unittest.constraints.IsScalar
+import matlab.unittest.constraints.IsFile
 basic = tc.TestData.basic;
+tc.assumeThat(basic, IsFile)
+
 s = h5read(basic, '/A0');
-tc.verifyTrue(isscalar(s))
+tc.verifyThat(s, IsScalar)
 tc.verifyEqual(s, 42)
 
 s = h5read(basic, '/A1');
@@ -114,13 +122,14 @@ function test_read(tc)
 
 function test_coerce(tc)
 import hdf5nc.h5save
+import matlab.unittest.constraints.IsFile
 basic = tc.TestData.basic;
 
 h5save(basic, '/int32', 0, "type", 'int32')
 h5save(basic, '/int64', 0, "type", 'int64')
 h5save(basic, '/float32', 0, "type", 'float32')
 
-tc.assumeTrue(isfile(basic))
+tc.assumeThat(basic, IsFile)
 
 tc.verifyClass(h5read(basic, '/int32'), 'int32')
 tc.verifyClass(h5read(basic, '/int64'), 'int64')
@@ -130,23 +139,26 @@ function test_coerce(tc)
 
 function test_rewrite(tc)
 import hdf5nc.h5save
+import matlab.unittest.constraints.IsFile
 basic = tc.TestData.basic;
+
 h5save(basic, '/A2', 3*magic(4))
-tc.assumeTrue(isfile(basic))
+
+tc.assumeThat(basic, IsFile)
 tc.verifyEqual(h5read(basic, '/A2'), 3*magic(4))
 end
 
 function test_string(tc)
 import hdf5nc.h5save
-h5save(tc.TestData.basic, "/a_string", "hello")
-h5save(tc.TestData.basic, "/a_char", 'there')
+basic = tc.TestData.basic;
+
+h5save(basic, "/a_string", "hello")
+h5save(basic, "/a_char", 'there')
 
-astr = h5read(tc.TestData.basic, "/a_string");
-achar = h5read(tc.TestData.basic, "/a_char");
+astr = h5read(basic, "/a_string");
+achar = h5read(basic, "/a_char");
 tc.verifyEqual(astr, "hello")
 tc.verifyEqual(achar, "there")
-tc.verifyClass(astr, "string")
-tc.verifyClass(achar, "string")
 end
 
 function test_real_only(tc)

+hdf5nc/test_netcdf.m

@@ -44,8 +44,10 @@ function test_get_variables(tc)
 
 function test_exists(tc)
 import hdf5nc.ncexists
+import matlab.unittest.constraints.IsScalar
+
 e0 = ncexists(tc.TestData.basic, 'A3');
-tc.verifyTrue(isscalar(e0))
+tc.verifyThat(e0, IsScalar)
 tc.verifyTrue(e0)
 
 tc.verifyFalse(ncexists(tc.TestData.basic, '/oops'))
@@ -58,14 +60,15 @@ function test_exists(tc)
 
 function test_size(tc)
 import hdf5nc.ncsize
+import matlab.unittest.constraints.IsScalar
 basic = tc.TestData.basic;
 
 s = ncsize(basic, 'A0');
-tc.verifyTrue(isscalar(s))
+tc.verifyThat(s, IsScalar)
 tc.verifyEqual(s, 1)
 
 s = ncsize(basic, 'A1');
-tc.verifyTrue(isscalar(s))
+tc.verifyThat(s, IsScalar)
 tc.verifyEqual(s, 2)
 
 s = ncsize(basic, 'A2');
@@ -83,10 +86,13 @@ function test_size(tc)
 
 
 function test_read(tc)
+import matlab.unittest.constraints.IsScalar
+import matlab.unittest.constraints.IsFile
 basic = tc.TestData.basic;
+tc.assumeThat(basic, IsFile)
 
 s = ncread(basic, '/A0');
-tc.verifyTrue(isscalar(s))
+tc.verifyThat(s, IsScalar)
 tc.verifyEqual(s, 42)
 
 s = ncread(basic, '/A1');
@@ -109,14 +115,14 @@ function test_read(tc)
 
 function test_coerce(tc)
 import hdf5nc.ncsave
-
+import matlab.unittest.constraints.IsFile
 basic = tc.TestData.basic;
 
 ncsave(basic, 'int32', 0, "type", 'int32')
 ncsave(basic, 'int64', 0, "type", 'int64')
 ncsave(basic, 'float32', 0, "type", 'float32')
 
-tc.assumeTrue(isfile(basic))
+tc.assumeThat(basic, IsFile)
 
 tc.verifyClass(h5read(basic, '/int32'), 'int32')
 tc.verifyClass(h5read(basic, '/int64'), 'int64')
@@ -126,9 +132,12 @@ function test_coerce(tc)
 
 function test_rewrite(tc)
 import hdf5nc.ncsave
+import matlab.unittest.constraints.IsFile
 basic = tc.TestData.basic;
+
 ncsave(basic, 'A2', 3*magic(4))
-tc.assumeTrue(isfile(basic))
+
+tc.assumeThat(basic, IsFile)
 tc.verifyEqual(ncread(basic, 'A2'), 3*magic(4))
 end