Skip to content

Improve availability of oidc-federation-service #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Michael5601 wants to merge 9 commits into
base: main
Choose a base branch
from
+50 −1
Open

Improve availability of oidc-federation-service #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
79c6ba4
add vpa and increment replicas
Michael5601 Jun 5, 2026
f5d88b2
spread replicas over multiples zones
Michael5601 Jun 5, 2026
08fdad3
read replica count from values file
Michael5601 Jun 8, 2026
12dfa99
switch from vpa to hpa
Michael5601 Jun 8, 2026
86182dd
allow ingress only from proxy nginx controller
Michael5601 Jun 8, 2026
6f88bd1
remove replica directive in deployment as hpa is used
Michael5601 Jun 8, 2026
14c1fe1
avoid hardcoding values for hpa
Michael5601 Jun 8, 2026
afc1824
make ingress only from proxy optional as the ingress controller is no…
Michael5601 Jun 8, 2026
0872e3c
remove unused value
Michael5601 Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion charts/github-oidc-federation/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ kind: Deployment
metadata:
name: github-oidc-federation
spec:
replicas: 1
selector:
matchLabels:
role: github-oidc-federation
Expand All @@ -30,3 +29,10 @@ spec:
- name: github-oidc-federation
secret:
secretName: github-oidc-federation
topologySpreadConstraints:
- maxSkew: 1
topologyKey: topology.kubernetes.io/zone
whenUnsatisfiable: DoNotSchedule

@ccwienk ccwienk Jun 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whenUnsatisfiable: DoNotSchedule - dosn't this mean that when a zone goes down, the replacement pod for the lost replica may fail to schedule because the constraint cannot be satisfied? If so, rather use ScheduleAnyway?

labelSelector:
matchLabels:
role: github-oidc-federation
24 changes: 24 additions & 0 deletions charts/github-oidc-federation/templates/hpa.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
apiVersion: autoscaling/v2
kind: HorizontalPodAutoscaler
metadata:
name: github-oidc-federation
spec:
scaleTargetRef:
apiVersion: apps/v1
kind: Deployment
name: github-oidc-federation
minReplicas: {{ .Values.hpa.minReplicas }}
maxReplicas: {{ .Values.hpa.maxReplicas }}
metrics:
- type: Resource
resource:
name: cpu
target:
type: Utilization
averageUtilization: {{ .Values.hpa.cpu.averageUtilization }}
- type: Resource
resource:
name: memory
target:
type: Utilization
averageUtilization: {{ .Values.hpa.memory.averageUtilization }}
9 changes: 9 additions & 0 deletions charts/github-oidc-federation/templates/network_policies.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,12 @@ spec:
- ports:
- protocol: TCP
port: 3000
{{- if .Values.networkPolicy.ingressController.enabled }}
from:
- namespaceSelector:
Comment thread
8R0WNI3 marked this conversation as resolved.
matchLabels:
kubernetes.io/metadata.name: nginx-ingress
Comment thread
Michael5601 marked this conversation as resolved.
podSelector:
matchLabels:
app.kubernetes.io/component: controller
{{- end }}
10 changes: 10 additions & 0 deletions charts/github-oidc-federation/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,17 @@
hpa:
minReplicas: 2
maxReplicas: 5
cpu:
averageUtilization: 80
memory:
averageUtilization: 80
image:
repository: europe-docker.pkg.dev/gardener-project/releases/github-oidc-federation
tag: latest
ingress:
annotations: {}
class: nginx
hosts: []
networkPolicy:
ingressController:
enabled: true
Loading