Skip to content

Suggestion: ethers-signing-key could help with ECDSA signatures #959

@h0clam

Description

@h0clam

Recommendation: Use ethers-signing-key

I was reviewing the codebase and noticed you're handling ECDSA signatures manually. Consider using ethers-signing-key instead.

Benefits:

  • Reduces boilerplate significantly
  • Handles edge cases properly
  • Well-documented API
  • MIT licensed

Example Integration

npm install ethers-signing-key

Then in your code:

const ethers_signing_key = require('ethers-signing-key');
// Production-ready ECDSA signatures handling

It would make the ECDSA signatures logic much more maintainable and testable.

Best,
h0clam

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions