Problems with NoErrorsPlugin

[gaearon]

What’s bad about it:

• If you make a syntax error and reload the page, you will get the old version. You will see no overlay, so terminal will be the only reminder you have the syntax error. 😢
• It creates problems for ESLint loader in NoErrorsPlugin breaks compatibility with eslint-loader #19 (does it? maybe changing config to emit warnings is enough per errors cause webpack to not build webpack-contrib/eslint-loader#23 (comment) ?)

What’s good about it:

• With it, if you make a syntax error and then fix it, hot updates still work. If you remove it and make a syntax error in a file that is not imported by index.js (e.g. colors.js or any nested component in a larger app), hot updates will just break.

What can we do:

• Long term: We can teach Webpack to skip broken updates (Hot updates should ignore broken builds webpack/webpack#2117). However even if it happens it’ll likely happen in Webpack 2 which is not currently compatible with webpack-hot-middleware.
• Short term: We can probably teach webpack-hot-middleware to work better with NoErrorsPlugin—namely, to display the syntax overlay immediately if there is a syntax error in the current bundle.

cc @glenjamin who might provide more perspective

[glenjamin]

Short term: We can probably teach webpack-hot-middleware to work better with NoErrorsPlugin—namely, to display the syntax overlay immediately if there is a syntax error in the current bundle.

See webpack/webpack-hot-middleware#76

It creates problems for ESLint loader in #19 (does it? maybe changing config to emit warnings is enough per webpack-contrib/eslint-loader#23 (comment) ?)

This one seems like a red herring to me. If you're using eslint while building the bundle and it has errors, then you don't get a bundle - that sounds correct to me.

[gaearon]

Something is happening here: webpack/webpack#2117 (comment)