We need a new column on HouseAuctions

[zebeleu]

Since old times and until today, when someone bids a house (bid limit) you don't get to see the actual limit value.
So if I first bid 1000 to start the auction, the value that will be displayed should be "0". If someone bids 500, the value will be 500, but the bidder remains the same, until someone outbids his limit.

So maybe we could create a new column BidLimit that could be used to control this situation. You wouldn't need to change the auction processing code since it will still use the BidAmount value as the actual value to take from the winner. But for whoever is using this structure, it would be clear on how to control these fields and adapt the website to it.

[zebeleu]

Plus some field to control house transfers too. A flag so if a player transfer the house to someone, it will only process if the receiver accepted the house transfer

[fusion32]

I'm not sure I understand it. Is that bid limit supposed to be some safe-guard for bidders? Like covering any bids up until that limit? Either way, that looks specific to the website.

As for the house transfer boolean, it's a good idea to prevent scams. I had thought of it as a table of "finalized" transfers but having such a boolean can make it become both "ongoing" and "finalized" transfers (probably?).

[zebeleu]

I'm not sure I understand it. Is that bid limit supposed to be some safe-guard for bidders? Like covering any bids up until that limit? Either way, that looks specific to the website.

As for the house transfer boolean, it's a good idea to prevent scams. I had thought of it as a table of "finalized" transfers but having such a boolean can make it become both "ongoing" and "finalized" transfers (probably?).

About the bid limit: in Tibia (since the beggining) every auction starts with amount 0. If some player bids 1000 gold, the auction will start with a bid of 0. If no one else bids it, the person will win the auction for 0 gold and not 1000. If someone bids 300, the current valid bid will be 300, but will still he hold by the first player which had the limit of 1000.
If someone bids 5000, that will be the new bid limit. But the current auction bid will be in 1000, which was the previous max limit.

No one gets to see the actual bid limit ever, except if you hold the bid limit.

In my code I created BidLimit in HouseAuctions and IsAccepted in HouseTransfers, and now I'm controlling the auction and transfers with those columns, and the game server should only process the transfers where IsAccepted is true.

[zebeleu]

The idea of this flag I mentioned is to make sure the transfer is only happening if the other part accepted it so ppl won't abuse it on transfering unwanted houses for high prices.
I don't think we need a finalized transfers control, since all assignments should be on HouseAssignments.

[eliaszarierom]

Here I created a separate table to serve the tibia-web server. Only after the user accepts the offer on the website does the data go to the HouseTransfers table; if the offer is not accepted, it is deleted during the server save once it has expired.
And regarding the bids, I am using the regular table as usual.

[zebeleu]

That works too.
I decided not creating another table so I wouldn't have to create another routine to process expiration case.
So I changed the current transfer processing to process if the accepted flag is true, and to discard if it's false.