Bug type: global variables

[mashdragon]

A bug type I've come across myself has been with forgetting to use the global keyword with global variables. Here's an example:

# A globally accessible list
current_labels = []

def reset_current_labels():
    """ Clears the label list """
    current_labels = []

The bug is that calling reset_current_labels() will not modify current_labels:

>>> current_labels.append('delete me')
>>> current_labels
['delete me']
>>> reset_current_labels()
>>> current_labels
['delete me']

The correct code would be

# A globally accessible list
current_labels = []

def reset_current_labels():
    """ Clears the label list """
    global current_labels
    current_labels = []

So to bug the code, you would remove one or more global statements.

[furlat]

Thanks for the suggestion, would this script satisfy your example ? (some of the bugs are unchecked and might not work )

OpenBugger/logic/logic_injector.py

Line 401 in 3b0a6e5

def using_wrong_variable_scope(script, errors_dict):

[mashdragon]

Almost. I think to reproduce the bug, the entire global declaration should be missing.