Move belongs_to tests to existing associations block

Author: RaymondFFT

spec/rails_admin/config/fields/base_spec.rb

@@ -74,27 +74,6 @@ class ConditionalValidationTest < Tableless
       end
     end
 
-    context 'on a belongs_to association' do
-      before do
-        class BelongsToTest < Tableless
-          belongs_to :draft, optional: true
-          belongs_to :team, optional: false
-          belongs_to :image, required: true
-          belongs_to :player, required: false
-        end
-      end
-
-      it 'respects optional on associations' do
-        expect(RailsAdmin.config('BelongsToTest').fields.detect { |f| f.name == :draft }).not_to be_required
-        expect(RailsAdmin.config('BelongsToTest').fields.detect { |f| f.name == :team }).to be_required
-      end
-
-      it 'respects required on associations' do
-        expect(RailsAdmin.config('BelongsToTest').fields.detect { |f| f.name == :image }).to be_required
-        expect(RailsAdmin.config('BelongsToTest').fields.detect { |f| f.name == :player }).not_to be_required
-      end
-    end
-
     context 'on a Paperclip installation' do
       it 'should detect required fields' do
         expect(RailsAdmin.config('Image').fields.detect { |f| f.name == :file }.with(object: Image.new)).to be_required
@@ -107,9 +86,15 @@ class RelTest < Tableless
           column :league_id, :integer
           column :division_id, :integer, nil, false
           column :player_id, :integer
+          column :team_id, :integer
+          column :draft_id, :integer
+          column :image_id, :integer
           belongs_to :league, optional: true
           belongs_to :division, optional: true
           belongs_to :player, optional: true
+          belongs_to :team, optional: false
+          belongs_to :draft, required: true
+          belongs_to :image, required: false
           validates_numericality_of(:player_id, only_integer: true)
         end
         @fields = RailsAdmin.config(RelTest).create.fields
@@ -132,6 +117,24 @@ class RelTest < Tableless
           expect(@fields.detect { |f| f.name == :player }.required?).to be_truthy
         end
       end
+
+      describe 'for belongs_to association with optional: false' do
+        it 'is required' do
+          expect(@fields.detect { |f| f.name == :team }.required?).to be_truthy
+        end
+      end
+
+      describe 'for belongs_to association with required: true' do
+        it 'is required' do
+          expect(@fields.detect { |f| f.name == :draft }.required?).to be_truthy
+        end
+      end
+
+      describe 'for belongs_to association with required: false' do
+        it 'is optional' do
+          expect(@fields.detect { |f| f.name == :image }.required?).to be_falsey
+        end
+      end
     end
   end