Skip to content
This repository was archived by the owner on Apr 13, 2024. It is now read-only.

Commit dc2b90b

Browse files
committed
Rename default sign algorithm to default algorithm
1 parent 2060e83 commit dc2b90b

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

httpsig/sign.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
from .sign_algorithms import SignAlgorithm
99
from .utils import *
1010

11-
DEFAULT_SIGN_ALGORITHM = "hs2019"
11+
DEFAULT_ALGORITHM = "hs2019"
1212

1313

1414
class Signer(object):
@@ -21,15 +21,15 @@ class Signer(object):
2121

2222
def __init__(self, secret, algorithm=None, sign_algorithm=None):
2323
if algorithm is None:
24-
algorithm = DEFAULT_SIGN_ALGORITHM
24+
algorithm = DEFAULT_ALGORITHM
2525

2626
assert algorithm in ALGORITHMS, "Unknown algorithm"
2727

2828
if sign_algorithm is not None and not issubclass(type(sign_algorithm), SignAlgorithm):
2929
raise HttpSigException("Unsupported digital signature algorithm")
3030

31-
if algorithm != DEFAULT_SIGN_ALGORITHM:
32-
print("Algorithm: {} is deprecated please update to {}".format(algorithm, DEFAULT_SIGN_ALGORITHM))
31+
if algorithm != DEFAULT_ALGORITHM:
32+
print("Algorithm: {} is deprecated please update to {}".format(algorithm, DEFAULT_ALGORITHM))
3333

3434
if isinstance(secret, six.string_types):
3535
secret = secret.encode("ascii")
@@ -106,7 +106,7 @@ class HeaderSigner(Signer):
106106

107107
def __init__(self, key_id, secret, algorithm=None, sign_algorithm=None, headers=None, sign_header='authorization'):
108108
if algorithm is None:
109-
algorithm = DEFAULT_SIGN_ALGORITHM
109+
algorithm = DEFAULT_ALGORITHM
110110

111111
super(HeaderSigner, self).__init__(secret=secret, algorithm=algorithm, sign_algorithm=sign_algorithm)
112112
self.headers = headers or ['date']

httpsig/tests/test_signature.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313
sys.path.insert(0, os.path.join(os.path.dirname(__file__), '..'))
1414

15-
sign.DEFAULT_SIGN_ALGORITHM = "hs2019"
15+
sign.DEFAULT_ALGORITHM = "hs2019"
1616

1717

1818
class TestSign(unittest.TestCase):

httpsig/verify.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import base64
55
import six
66

7-
from .sign import Signer, DEFAULT_SIGN_ALGORITHM
7+
from .sign import Signer, DEFAULT_ALGORITHM
88
from .sign_algorithms import SignAlgorithm
99
from .utils import *
1010

@@ -90,10 +90,10 @@ def __init__(self, headers, secret, required_headers=None, method=None,
9090
self.path = path
9191
self.host = host
9292

93-
if self.auth_dict['algorithm'] != DEFAULT_SIGN_ALGORITHM:
94-
print("Algorithm: {} is deprecated please update to {}".format(self.auth_dict['algorithm'], DEFAULT_SIGN_ALGORITHM))
95-
elif self.auth_dict['algorithm'] == DEFAULT_SIGN_ALGORITHM and sign_algorithm is None:
96-
raise HttpSigException("Required sign algorithm for {} algorithm not set".format(DEFAULT_SIGN_ALGORITHM))
93+
if self.auth_dict['algorithm'] != DEFAULT_ALGORITHM:
94+
print("Algorithm: {} is deprecated please update to {}".format(self.auth_dict['algorithm'], DEFAULT_ALGORITHM))
95+
elif self.auth_dict['algorithm'] == DEFAULT_ALGORITHM and sign_algorithm is None:
96+
raise HttpSigException("Required sign algorithm for {} algorithm not set".format(DEFAULT_ALGORITHM))
9797

9898
super(HeaderVerifier, self).__init__(
9999
secret, algorithm=self.auth_dict['algorithm'], sign_algorithm=sign_algorithm)

0 commit comments

Comments
 (0)