feat: add lazy loading feature, optimize code related to calamine via PR #9 from fuhan666/feature/optimize-calamine

Author: fuhan666

CHANGELOG.md

@@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - Support dimming other areas while editing
 - Remember the selected cell when switching between sheets
+- Added optional lazy loading for xlsx and xlsb files to improve performance with large files (enabled with -l flag)
 
 ### Fixed
 
@@ -21,6 +22,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Edit cell content using vim shortcuts
 - Multiple UI improvements
 - Replace ratatui_textarea with tui_textarea
+- Upgraded calamine to version 0.27.0
 
 ## [0.2.0] - 2025-04-27
 

Cargo.lock

@@ -12,7 +12,7 @@ exclude = ["/.github", "CHANGELOG.md", ".gitignore"]
 [dependencies]
 ratatui = "0.24.0"
 crossterm = "0.27.0"
-calamine = "0.22.1"
+calamine = "0.27.0"
 anyhow = "1.0.79"
 clap = { version = "4.5.0", features = ["derive"] }
 rust_xlsxwriter = "0.86.0"

Cargo.toml

@@ -75,6 +75,7 @@ excel-cli path/to/your/file.xlsx -j > data.json # (example) Save JSON output to
 - `--json-export`, `-j`: Export all sheets to JSON and output to stdout (for piping)
 - `--direction`, `-d`: Header direction in Excel: 'h' for horizontal (top rows), 'v' for vertical (left columns). Default: 'h'
 - `--header-count`, `-r`: Number of header rows (for horizontal) or columns (for vertical) in Excel. Default: 1
+- `--lazy-loading`, `-l`: Enable lazy loading for large Excel files (only loads data when needed)
 
 ## User Interface
 

README.md

@@ -75,6 +75,7 @@ excel-cli path/to/your/file.xlsx -j > data.json # （示例）将JSON输出保
 - `--json-export`, `-j`：将所有工作表导出为 JSON 并输出到 stdout（用于管道传输）
 - `--direction`, `-d`：Excel 中的表头方向：'h'表示水平（顶部行），'v'表示垂直（左侧列）。默认：'h'
 - `--header-count`, `-r`：Excel 中的表头行数（水平方向）或列数（垂直方向）。默认：1
+- `--lazy-loading`, `-l`：启用大型 Excel 文件的懒加载功能（仅在需要时加载数据）
 
 ## 用户界面
 

README_zh.md

@@ -14,6 +14,7 @@ pub struct CellAction {
 }
 
 impl CellAction {
+    #[must_use]
     pub fn new(
         sheet_index: usize,
         sheet_name: String,

src/actions/cell.rs

@@ -2,13 +2,12 @@ use super::types::{ActionCommand, ActionType};
 
 impl ActionCommand {
     // Returns the action type of this command
+    #[must_use]
     pub fn get_action_type(&self) -> ActionType {
         match self {
             ActionCommand::Cell(action) => match action.action_type {
-                ActionType::Edit => ActionType::Edit,
-                ActionType::Cut => ActionType::Cut,
                 ActionType::Paste => ActionType::Paste,
-                _ => ActionType::Edit, // Default case
+                _ => ActionType::Edit, // Default case including Edit and Cut
             },
             ActionCommand::Row(_) => ActionType::DeleteRow,
             ActionCommand::MultiRow(_) => ActionType::DeleteMultiRows,

src/actions/command.rs

@@ -13,6 +13,7 @@ impl Default for UndoHistory {
 }
 
 impl UndoHistory {
+    #[must_use]
     pub fn new() -> Self {
         Self {
             undo_stack: Vec::with_capacity(100), // Pre-allocate capacity
@@ -44,6 +45,7 @@ impl UndoHistory {
         }
     }
 
+    #[must_use]
     pub fn all_undone(&self) -> bool {
         self.undo_stack.is_empty()
     }

src/actions/history.rs

@@ -10,7 +10,7 @@ impl AppState<'_> {
     pub fn start_editing(&mut self) {
         self.input_mode = InputMode::Editing;
         let content = self.get_cell_content(self.selected_cell.0, self.selected_cell.1);
-        self.input_buffer = content.clone();
+        self.input_buffer.clone_from(&content);
 
         // Initialize TextArea with content and settings
         let mut text_area = tui_textarea::TextArea::default();
@@ -57,7 +57,7 @@ impl AppState<'_> {
             let old_cell = self.workbook.get_current_sheet().data[row][col].clone();
 
             let mut new_cell = old_cell.clone();
-            new_cell.value = content.clone();
+            new_cell.value.clone_from(&content);
 
             let cell_action = CellAction::new(
                 sheet_index,
@@ -134,7 +134,7 @@ impl AppState<'_> {
             let old_cell = self.workbook.get_current_sheet().data[row][col].clone();
 
             let mut new_cell = old_cell.clone();
-            new_cell.value = content.clone();
+            new_cell.value.clone_from(&content);
 
             let cell_action = CellAction::new(
                 sheet_index,

src/app/edit.rs

@@ -108,9 +108,9 @@ impl AppState<'_> {
                 || sheet.data[row][col].value.is_empty();
 
             let message = if is_cell_empty {
-                format!("Jumped to first non-empty cell ({})", dir_name)
+                format!("Jumped to first non-empty cell ({dir_name})")
             } else {
-                format!("Jumped to last non-empty cell ({})", dir_name)
+                format!("Jumped to last non-empty cell ({dir_name})")
             };
 
             self.add_notification(message);