Netcoreapp3 (#7359)

* Use netcoresdk 3.0

* Use appdomain and load context

* temp

* Execute in appdomain, or assemblyloadcontext

* fscore

* linux

* Try to publish test logs from Linux/MacOS

* Copy paste error

* netcoreapp3

* feedback

Author: KevinRansom

NuGet.config

@@ -22,6 +22,14 @@
     <add key="vs-impl" value="https://vside.myget.org/F/vs-impl/api/v3/index.json" />
     <add key="roslyn_concord" value="https://myget.org/F/roslyn_concord/api/v3/index.json" />
     <add key="devcore" value="https://vside.myget.org/F/devcore/api/v3/index.json" />
+
+    <!-- These keys can be removed once 16.3 has shipped, they are necessary to build with net16.3 previews -->
+    <add key="dotnet-windowsdesktop" value="https://dotnetfeed.blob.core.windows.net/dotnet-windowsdesktop/index.json" />
+    <add key="aspnet-aspnetcore" value="https://dotnetfeed.blob.core.windows.net/aspnet-aspnetcore/index.json" />
+    <add key="aspnet-aspnetcore-tooling" value="https://dotnetfeed.blob.core.windows.net/aspnet-aspnetcore-tooling/index.json" />
+    <add key="aspnet-entityframeworkcore" value="https://dotnetfeed.blob.core.windows.net/aspnet-entityframeworkcore/index.json" />
+    <add key="aspnet-extensions" value="https://dotnetfeed.blob.core.windows.net/aspnet-extensions/index.json" />
+    <add key="gRPC repository" value="https://grpc.jfrog.io/grpc/api/nuget/v3/grpc-nuget-dev" />
   </packageSources>
   <disabledPackageSources>
     <clear />

eng/Build.ps1

@@ -174,7 +174,7 @@ function BuildSolution() {
     $officialBuildId = if ($official) { $env:BUILD_BUILDNUMBER } else { "" }
     $toolsetBuildProj = InitializeToolset
     $quietRestore = !$ci
-    $testTargetFrameworks = if ($testCoreClr) { "netcoreapp2.1" } else { "" }
+    $testTargetFrameworks = if ($testCoreClr) { "netcoreapp3.0" } else { "" }
 
     # Do not set the property to true explicitly, since that would override value projects might set.
     $suppressExtensionDeployment = if (!$deployExtensions) { "/p:DeployExtension=false" } else { "" }
@@ -309,7 +309,7 @@ try {
         Prepare-TempDir
         EnablePreviewSdks
 
-        # enable us to build netcoreapp2.1 binaries
+        # enable us to build netcoreapp2.1 product binaries
         $global:_DotNetInstallDir = Join-Path $RepoRoot ".dotnet"
         InstallDotNetSdk $global:_DotNetInstallDir $GlobalJson.tools.dotnet
         InstallDotNetSdk $global:_DotNetInstallDir "2.1.503"
@@ -332,7 +332,7 @@ try {
     }
 
     $desktopTargetFramework = "net472"
-    $coreclrTargetFramework = "netcoreapp2.1"
+    $coreclrTargetFramework = "netcoreapp3.0"
 
     if ($testDesktop -and -not $noVisualStudio) {
         TestUsingNUnit -testProject "$RepoRoot\tests\FSharp.Compiler.UnitTests\FSharp.Compiler.UnitTests.fsproj" -targetFramework $desktopTargetFramework

eng/build.sh

@@ -269,7 +269,7 @@ InstallDotNetSdk $_InitializeDotNetCli 2.1.503
 BuildSolution
 
 if [[ "$test_core_clr" == true ]]; then
-  coreclrtestframework=netcoreapp2.1
+  coreclrtestframework=netcoreapp3.0
   TestUsingNUnit --testproject "$repo_root/tests/FSharp.Compiler.UnitTests/FSharp.Compiler.UnitTests.fsproj" --targetframework $coreclrtestframework
   TestUsingNUnit --testproject "$repo_root/tests/FSharp.Compiler.LanguageServer.UnitTests/FSharp.Compiler.LanguageServer.UnitTests.fsproj" --targetframework $coreclrtestframework
   TestUsingNUnit --testproject "$repo_root/tests/FSharp.Build.UnitTests/FSharp.Build.UnitTests.fsproj" --targetframework $coreclrtestframework

src/fsharp/FSharp.Compiler.LanguageServer/FSharp.Compiler.LanguageServer.fsproj

@@ -4,8 +4,8 @@
   <PropertyGroup>
     <OutputType>Exe</OutputType>
     <TargetExt>.exe</TargetExt>
-    <TargetFrameworks>net472;netcoreapp2.1</TargetFrameworks>
-    <TargetFrameworks Condition="'$(OS)' == 'Unix'">netcoreapp2.1</TargetFrameworks>
+    <TargetFrameworks>net472;netcoreapp3.0</TargetFrameworks>
+    <TargetFrameworks Condition="'$(OS)' == 'Unix'">netcoreapp3.0</TargetFrameworks>
     <IsPackable>true</IsPackable>
     <PackageDescription>Implements the Language Server Protocol (LSP) for F#.</PackageDescription>
     <ExcludeFromSourceBuild>true</ExcludeFromSourceBuild>